KFP-783: fix 13

Author: kuziel-radziwonm

.github/workflows/run-perf-tests.yaml

@@ -110,6 +110,33 @@ jobs:
           --out csv=/test/test_results.csv \
           /test/script.js
 
+    - name: Lambda cleanup phase
+      if: always()
+      env:
+        PROVISIONED_CONCURRENCY: 5
+        WARMUP_DURATION_MS: 30000
+      run: |
+        # Set Lambda function name based on environment (same logic as warmup)
+        if [ "${{ github.event_name }}" = "schedule" ]; then
+          ENV="DEV"
+        else
+          ENV="${{ github.event.inputs.environment }}"
+        fi
+        
+        if [ "$ENV" = "STAGING" ]; then
+          LAMBDA_FUNCTION_NAME="kainoscore-app-staging"
+        else
+          LAMBDA_FUNCTION_NAME="kainoscore-app-dev"
+        fi
+        
+        export LAMBDA_FUNCTION_NAME
+        echo "Starting Lambda cleanup to remove provisioned concurrency..."
+        echo "Environment: $ENV"
+        echo "Lambda Function: $LAMBDA_FUNCTION_NAME"
+        cd CoreDeployable/test/performance
+        node cleanup.js
+        echo "Lambda cleanup completed!"
+
     - name: Upload test results
       uses: actions/upload-artifact@v4
       if: always()

CoreDeployable/test/performance/warmup.js

@@ -29,27 +29,6 @@ async function setProvisionedConcurrency(functionName, concurrency) {
   }
 }
 
-async function removeProvisionedConcurrency(functionName) {
-  console.log(`Removing provisioned concurrency for function: ${functionName}`);
-  
-  const command = new DeleteProvisionedConcurrencyConfigCommand({
-    FunctionName: functionName,
-    Qualifier: LAMBDA_QUALIFIER,
-  });
-
-  try {
-    await lambdaClient.send(command);
-    console.log(`Provisioned concurrency removed successfully`);
-  } catch (error) {
-    if (error.name === 'ResourceNotFoundException') {
-      console.log(`No provisioned concurrency configuration found (already removed)`);
-    } else {
-      console.error(`Failed to remove provisioned concurrency:`, error.message);
-      throw error;
-    }
-  }
-}
-
 async function waitForProvisionedConcurrency(functionName, maxWaitTime = 180000) {
   console.log(`Waiting for provisioned concurrency to become ready`);
 
@@ -103,20 +82,14 @@ async function warmupLambda() {
     if (isReady) {
       console.log(`Keeping Lambda warm for ${WARMUP_DURATION_MS}ms...`);
       await new Promise(resolve => setTimeout(resolve, WARMUP_DURATION_MS));
-      console.log('Warmup completed!');
+      console.log('Warmup completed! Lambda is ready for performance tests.');
     } else {
       console.log('Proceeding with performance tests even though warmup didn\'t fully complete.');
     }
 
   } catch (error) {
     console.error('Warmup failed:', error.message);
     throw error;
-  } finally {
-    try {
-      await removeProvisionedConcurrency(FUNCTION_NAME);
-    } catch (cleanupError) {
-      console.error('Failed to clean up provisioned concurrency:', cleanupError.message);
-    }
   }
 }