Skip to content

Improve SPI Service Detection #366

@Peterdoo

Description

@Peterdoo

Dear Jan,

I have seen in the code that on some places the function seems_epg is used. This one tries to guess whether a sevice is SPI/EPG based on the service name. However this is very problematic as SPI/EPG service name can be anything. For example if some operator would name it "Programmagids", it would not be recognized as SPI.

I would suggest to use the correct identification based on the IDs.

For example in RadioInterface::epgTimer_timeOut:

  • The function theEnsembleHandler->getEpgServices() should return all data services without looking at the name.

  • Then modifying the line
    if (pd. DSCTy == 60) {
    to
    if ((pd. DSCTy == 60) && (pd. appType == 7)) {

would make sure that the service is SPI/EPG.

I would suggest to remove the function seems_epg completely and identify SPI on all places by using
serviceType (index) == PACKET_SERVICE
pd. DSCTy == 60
pd. appType == 7

Apparently there are some MUXes (Norway?) that carry more than one SPI service. I don't know whether that case is considered in the code.

Best regards,
Peter

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions