Skip to content

Places assets inline, rather than relying on fs? #58

@jonathon-love

Description

@jonathon-love

hi,

we've used dialogs for some time, but we're in the process of updating our toolchain to use vite rather than browserify. it seems that browserify (or is it babel?) made it really easy to sub dialogs' calls to fs.readFileSync() ... however i don't think this is so straightforward with modern tools like vite.

what do you think about replacing the fs.readFileSync() calls in dialogs with inlined resources?

it is a bit funny that dialogs makes use of both fs.readFileSync() and document.appendChild() meaning in it's unprocessed form, it can't run in the browser, or in node.

with thanks

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions