Could not resolve type JKToolKit.Spectre.AutoCompletion.Completion.Internals.CompleteCommand

[HackXIt]

Currently when executing my ConsoleApp with added JKToolKit I am getting:

Error: Could not resolve type 'JKToolKit.Spectre.AutoCompletion.Completion.Internals.CompleteCommand'.

Any ideas why that might occur?

My ConsoleApp setup:

/// <summary>
        /// Creates a configured CommandApp and builds the DI ServiceProvider.
        /// </summary>
        /// <returns>
        /// Tuple of (CommandApp app, IServiceProvider serviceProvider).
        /// The app is fully configured with commands, and the provider is built and ready to resolve services.
        /// </returns>
        public static (ICommandApp App, IServiceProvider ServiceProvider) Create()
        {
            // Setup DI container and register services
            var services = new ServiceCollection();
            // ... adding various services ...
            
            services.AddSingleton<InteractiveCommand>();

            // Use a custom TypeRegistrar for Spectre.Console to enable DI
            var registrar = new TypeRegistrar(services);
            var app = new CommandApp<InteractiveCommand>(registrar); // Default command is InteractiveCommand
            
            services.AddSingleton<ICommandApp>(app); 

            // Configure command hierarchy and options
            app.Configure(config =>
            {
                config.ValidateExamples(); // ensure examples in help are valid

                config.AddAutoCompletion(c => c.AddPowershell());
               // ... rest
            }
            return (app, registrar.BuiltServiceProvider);
        }

[HackXIt]

I'm using a custom TypeRegistrar and TypeResolver:

TypeRegistrar.cs:

using Microsoft.Extensions.DependencyInjection;
using Spectre.Console.Cli;

namespace ToscaReportAnalyzer.Infrastructure;

/// <summary>
/// Adapter to integrate Microsoft DI container with Spectre.Console.Cli.
/// </summary>
public class TypeRegistrar(IServiceCollection serviceCollection) : ITypeRegistrar
{
    private readonly IServiceCollection _serviceCollection = serviceCollection;
    private IServiceProvider? _builtProvider;

    /// <summary>
    /// Build the ITypeResolver (creates the ServiceProvider).
    /// </summary>
    public ITypeResolver Build()
    {
        // Only build the ServiceProvider once to preserve singletons across multiple runs
        _builtProvider ??= _serviceCollection.BuildServiceProvider();
        var scope = _builtProvider.CreateScope();
        return new TypeResolver(scope);
    }

    /// <summary>
    /// Registers a type mapping in the DI container.
    /// </summary>
    public void Register(Type service, Type implementation)
    {
        _serviceCollection.AddSingleton(service, implementation);
    }

    /// <summary>
    /// Registers a specific instance in the DI container.
    /// </summary>
    public void RegisterInstance(Type service, object implementation)
    {
        _serviceCollection.AddSingleton(service, implementation);
    }

    /// <summary>
    /// Registers a factory method for a service (lazy instance creation).
    /// </summary>
    public void RegisterLazy(Type service, Func<object> func)
    {
        ArgumentNullException.ThrowIfNull(func);
        _serviceCollection.AddSingleton(service, (provider) => func());
    }

    /// <summary>
    /// Exposes the built ServiceProvider (after Build has been called).
    /// </summary>
    public IServiceProvider BuiltServiceProvider
    {
        get
        {
            if (_builtProvider == null)
            {
                // Lazy-build ServiceProvider in case it hasn't been called yet.
                Build();
            }
            return _builtProvider ?? throw new InvalidOperationException("ServiceProvider has not been successfully built (null).");
        }
    }
}

TypeResolver.cs:

using Microsoft.Extensions.DependencyInjection;
using Spectre.Console.Cli;

namespace ToscaReportAnalyzer.Infrastructure;
public class TypeResolver(IServiceScope scope) : ITypeResolver, IDisposable
{
    private readonly IServiceScope _scope = scope ?? throw new ArgumentNullException(nameof(scope));

    public object? Resolve(Type? type)
    {
        if (type == null)
        {
            return null;
        }
        // Use the service provider to resolve the requested type (or return null if not registered)
        return _scope.ServiceProvider.GetService(type);
    }

    public void Dispose()
    {
        // Dispose the service provider if it is disposable (to dispose of any scoped services, etc.)
        if (_scope is IDisposable disposable)
        {
            disposable.Dispose();
        }
    }
}

But even then, in debugging I can see the type being successfully registered, I can't really pin down why it doesn't seem to work.

[HackXIt]

It is related to this error:

System.ArgumentNullException: Value cannot be null. (Parameter 'configuration')
   at JKToolKit.Spectre.AutoCompletion.Completion.Internals.CompleteCommand.TryBuildResolverFromConfiguration(IConfiguration configuration)
   at JKToolKit.Spectre.AutoCompletion.Completion.Internals.CompleteCommand..ctor(DefaultTypeResolver resolver1, ITypeResolver resolver2, IConfiguration configuration)
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.CreateServiceAccessor(ServiceIdentifier serviceIdentifier)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier serviceIdentifier, ServiceProviderEngineScope serviceProviderEngineScope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope.GetService(Type serviceType)
   at ToscaReportAnalyzer.Infrastructure.TypeResolver.Resolve(Type type) in C:\Users\nirie\git-stash\Tosca-API-Exploration\ToscaReportAnalyzer\Infrastructure\TypeResolver.cs:line 16
   at Spectre.Console.Cli.TypeResolverAdapter.Resolve(Type type) in /_/src/Spectre.Console.Cli/Internal/TypeResolverAdapter.cs:line 21

So for some reason beyond me, dependency injection does not work as expected with your internal command.

[HackXIt]

@JKamsker

I think your ctor logic has a bug.

You first set the resolver via ITypeResolver? resolver = resolver1 ?? resolver2 ?? TryBuildResolverFromConfiguration(configuration);

And inside TryBuildResolverFromConfiguration, you are raising an ArgumentNullException, if the configuration is null:

private static ITypeResolver TryBuildResolverFromConfiguration(IConfiguration? configuration)
    {
        ITypeResolver? resolver;
        if (configuration is null)
        {
            throw new ArgumentNullException(nameof(configuration));
        }

But later, if the configuration is null, you actually try to resolve the configuration:

if (configuration is null)
{
    configuration = resolver.Resolve(typeof(IConfiguration)) as IConfiguration;
}

That code confuses me quite a bit.

Since your constructor uses default values, if the DI is unable to provide the resolver or the configuration, then your code will always fails, since configuration is null.

I don't understand, why the DI is unable to provide the resolver, resulting in your code trying to retrieve the resolver manually.

You're also doing some reflection in TryBuildResolverFromConfiguration, which requires that the TypeRegistrar conforms with the expected private fields.

Code Snippet

public CompleteCommand ( DefaultTypeResolver? resolver1 = default, ITypeResolver? resolver2 = default, IConfiguration? configuration = default ) { ITypeResolver? resolver = resolver1 ?? resolver2 ?? TryBuildResolverFromConfiguration(configuration); CommandModel? commandModel = resolver.Resolve(typeof(CommandModel)) as CommandModel; if (configuration is null) { configuration = resolver.Resolve(typeof(IConfiguration)) as IConfiguration; } _model = commandModel ?? throw new ArgumentNullException(nameof(commandModel)); _configuration = configuration ?? throw new ArgumentNullException(nameof(configuration)); _typeResolver = resolver; _writer = configuration.Settings.Console.GetConsole(); } private static ITypeResolver TryBuildResolverFromConfiguration(IConfiguration? configuration) { ITypeResolver? resolver; if (configuration is null) { throw new ArgumentNullException(nameof(configuration)); } var registrar = configuration.Settings.Registrar as TypeRegistrar; if (registrar is null) { throw new ArgumentNullException(nameof(registrar)); } //var reg = registrar._registrar; var field = registrar.GetType().GetField("_registrar", BindingFlags.NonPublic | BindingFlags.Instance); if (field is null) { throw new ArgumentNullException(nameof(field)); } var reg = field.GetValue(registrar) as ITypeRegistrar; if (reg is null) { throw new ArgumentNullException(nameof(reg)); } resolver = reg.Build(); return resolver; }