From 8d1ba3391fd0afe625be26cebb48f7cfcf3ea7b4 Mon Sep 17 00:00:00 2001 From: ayman abdelghany Date: Fri, 20 May 2016 18:34:51 +0200 Subject: [PATCH] Primitives should not be boxed just for "String" conversion --- .../integreight/onesheeld/MainActivity.java | 2 +- .../onesheeld/model/InternetRequest.java | 4 ++-- .../popup/FirmwareUpdatingPopup.java | 2 +- .../shields/controller/ClockShield.java | 24 +++++++++---------- .../shields/controller/DataLoggerShield.java | 4 ++-- .../fragments/AccelerometerFragment.java | 6 ++--- .../shields/fragments/GravityFragment.java | 6 ++--- .../shields/fragments/GyroscopeFragment.java | 6 ++--- .../fragments/MagnetometerFragment.java | 6 ++--- .../fragments/OrientationFragment.java | 6 ++--- 10 files changed, 33 insertions(+), 33 deletions(-) diff --git a/oneSheeld/src/main/java/com/integreight/onesheeld/MainActivity.java b/oneSheeld/src/main/java/com/integreight/onesheeld/MainActivity.java index c5437850e..214ff02b7 100644 --- a/oneSheeld/src/main/java/com/integreight/onesheeld/MainActivity.java +++ b/oneSheeld/src/main/java/com/integreight/onesheeld/MainActivity.java @@ -324,7 +324,7 @@ public void onClick(View v) { } getThisApplication().getTracker().send( new HitBuilders.ScreenViewBuilder() - .setCustomDimension(2, version + "") + .setCustomDimension(2, String.valueOf(version)) .build()); } }); diff --git a/oneSheeld/src/main/java/com/integreight/onesheeld/model/InternetRequest.java b/oneSheeld/src/main/java/com/integreight/onesheeld/model/InternetRequest.java index f81ec0a2b..a045173a9 100644 --- a/oneSheeld/src/main/java/com/integreight/onesheeld/model/InternetRequest.java +++ b/oneSheeld/src/main/java/com/integreight/onesheeld/model/InternetRequest.java @@ -179,7 +179,7 @@ public void onFinish() { public InternetResponse getResponse() { try { - return InternetManager.getInstance().getCachDB().get(id + "", InternetResponse.class); + return InternetManager.getInstance().getCachDB().get(String.valueOf(id), InternetResponse.class); } catch (SnappydbException e) { return null; } @@ -187,7 +187,7 @@ public InternetResponse getResponse() { public void setResponse(InternetResponse response) { try { - InternetManager.getInstance().getCachDB().put(id + "", response); + InternetManager.getInstance().getCachDB().put(String.valueOf(id), response); } catch (SnappydbException e) { e.printStackTrace(); } diff --git a/oneSheeld/src/main/java/com/integreight/onesheeld/popup/FirmwareUpdatingPopup.java b/oneSheeld/src/main/java/com/integreight/onesheeld/popup/FirmwareUpdatingPopup.java index 0fc7b5acc..7498fbe3a 100644 --- a/oneSheeld/src/main/java/com/integreight/onesheeld/popup/FirmwareUpdatingPopup.java +++ b/oneSheeld/src/main/java/com/integreight/onesheeld/popup/FirmwareUpdatingPopup.java @@ -288,7 +288,7 @@ public void onFailure(int statusCode, Throwable error) { changeSlogan("Error Downloading!", COLOR.RED); setUpgrade(); - Log.d("bootloader", statusCode + ""); + Log.d("bootloader", String.valueOf(statusCode)); activity.getThisApplication() .getTracker() .send(new HitBuilders.EventBuilder() diff --git a/oneSheeld/src/main/java/com/integreight/onesheeld/shields/controller/ClockShield.java b/oneSheeld/src/main/java/com/integreight/onesheeld/shields/controller/ClockShield.java index 23237be88..d4cffe14e 100644 --- a/oneSheeld/src/main/java/com/integreight/onesheeld/shields/controller/ClockShield.java +++ b/oneSheeld/src/main/java/com/integreight/onesheeld/shields/controller/ClockShield.java @@ -41,9 +41,9 @@ public void run() { frame.addByteArgument((byte) calendar.get(Calendar.SECOND)); sendShieldFrame(frame); } - String hour = calendar.get(Calendar.HOUR_OF_DAY) + ""; - String min = calendar.get(Calendar.MINUTE) + ""; - String sec = calendar.get(Calendar.SECOND) + ""; + String hour = String.valueOf(calendar.get(Calendar.HOUR_OF_DAY)); + String min = String.valueOf(calendar.get(Calendar.MINUTE)); + String sec = String.valueOf(calendar.get(Calendar.SECOND)); if (eventHandler != null) eventHandler.onTimeChanged("" + (hour.length() == 1 ? "0" + hour : hour) + ":" @@ -78,9 +78,9 @@ public ControllerParent> init(String tag) { // frame.addByteArgument((byte) year); sendShieldFrame(frame); - String hour = calendar.get(Calendar.HOUR_OF_DAY) + ""; - String min = calendar.get(Calendar.MINUTE) + ""; - String sec = calendar.get(Calendar.SECOND) + ""; + String hour = String.valueOf(calendar.get(Calendar.HOUR_OF_DAY)); + String min = String.valueOf(calendar.get(Calendar.MINUTE)); + String sec = String.valueOf(calendar.get(Calendar.SECOND)); if (eventHandler != null) eventHandler.onTimeChanged("" + (hour.length() == 1 ? "0" + hour : hour) + ":" @@ -127,9 +127,9 @@ public void onNewShieldFrameReceived(ShieldFrame clock_frame) { // frame.addByteArgument((byte) year); sendShieldFrame(frame); - String hour = calendar.get(Calendar.HOUR_OF_DAY) + ""; - String min = calendar.get(Calendar.MINUTE) + ""; - String sec = calendar.get(Calendar.SECOND) + ""; + String hour = String.valueOf(calendar.get(Calendar.HOUR_OF_DAY)); + String min = String.valueOf(calendar.get(Calendar.MINUTE)); + String sec = String.valueOf(calendar.get(Calendar.SECOND)); if (eventHandler != null) eventHandler.onTimeChanged("" + (hour.length() == 1 ? "0" + hour : hour) + ":" @@ -281,9 +281,9 @@ public void onReceive(Context context, Intent intent) { } } setTime(); - String hour = calendar.get(Calendar.HOUR_OF_DAY) + ""; - String min = calendar.get(Calendar.MINUTE) + ""; - String sec = calendar.get(Calendar.SECOND) + ""; + String hour = String.valueOf(calendar.get(Calendar.HOUR_OF_DAY)); + String min = String.valueOf(calendar.get(Calendar.MINUTE)); + String sec = String.valueOf(calendar.get(Calendar.SECOND)); if (eventHandler != null) eventHandler.onTimeChanged( "" + (hour.length() == 1 ? "0" + hour : hour) + ":" diff --git a/oneSheeld/src/main/java/com/integreight/onesheeld/shields/controller/DataLoggerShield.java b/oneSheeld/src/main/java/com/integreight/onesheeld/shields/controller/DataLoggerShield.java index 1a786e267..2c5fbc511 100644 --- a/oneSheeld/src/main/java/com/integreight/onesheeld/shields/controller/DataLoggerShield.java +++ b/oneSheeld/src/main/java/com/integreight/onesheeld/shields/controller/DataLoggerShield.java @@ -192,8 +192,8 @@ public void saveData() { folder.mkdirs(); } fullFileName = (fileName == null - || fileName.length() == 0 ? new Date() - .getTime() + "" + || fileName.length() == 0 ? String.valueOf(new Date() + .getTime()) : fileName + " - " + new Date() .getTime()) + ".csv"; filePath = Environment diff --git a/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/AccelerometerFragment.java b/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/AccelerometerFragment.java index 1ba8ac93e..af8a716d4 100644 --- a/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/AccelerometerFragment.java +++ b/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/AccelerometerFragment.java @@ -87,7 +87,7 @@ public void onSensorValueChangedFloat(final float[] value) { @Override public void run() { if (canChangeUI()) - x.setText("" + value[0]); + x.setText(String.valueOf(value[0])); } }); y.post(new Runnable() { @@ -95,7 +95,7 @@ public void run() { @Override public void run() { if (canChangeUI()) - y.setText("" + value[1]); + y.setText(String.valueOf(value[1])); } }); z.post(new Runnable() { @@ -103,7 +103,7 @@ public void run() { @Override public void run() { if (canChangeUI()) - z.setText("" + value[2]); + z.setText(String.valueOf(value[2])); } }); diff --git a/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/GravityFragment.java b/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/GravityFragment.java index 9866aafd0..220c96b71 100644 --- a/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/GravityFragment.java +++ b/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/GravityFragment.java @@ -79,7 +79,7 @@ public void onSensorValueChangedFloat(final float[] value) { @Override public void run() { if (canChangeUI()) - x.setText("" + value[0]); + x.setText(String.valueOf(value[0])); } }); y.post(new Runnable() { @@ -87,7 +87,7 @@ public void run() { @Override public void run() { if (canChangeUI()) - y.setText("" + value[1]); + y.setText(String.valueOf(value[1])); } }); z.post(new Runnable() { @@ -95,7 +95,7 @@ public void run() { @Override public void run() { if (canChangeUI()) - z.setText("" + value[2]); + z.setText(String.valueOf(value[2])); } }); diff --git a/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/GyroscopeFragment.java b/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/GyroscopeFragment.java index 859b1bcda..21a389be5 100644 --- a/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/GyroscopeFragment.java +++ b/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/GyroscopeFragment.java @@ -81,7 +81,7 @@ public void onSensorValueChangedFloat(final float[] value) { @Override public void run() { if (canChangeUI()) - x.setText("" + value[0]); + x.setText(String.valueOf(value[0])); } }); y.post(new Runnable() { @@ -89,7 +89,7 @@ public void run() { @Override public void run() { if (canChangeUI()) - y.setText("" + value[1]); + y.setText(String.valueOf(value[1])); } }); z.post(new Runnable() { @@ -97,7 +97,7 @@ public void run() { @Override public void run() { if (canChangeUI()) - z.setText("" + value[2]); + z.setText(String.valueOf(value[2])); } }); diff --git a/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/MagnetometerFragment.java b/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/MagnetometerFragment.java index 921d08fa2..450b3ffdf 100644 --- a/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/MagnetometerFragment.java +++ b/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/MagnetometerFragment.java @@ -83,7 +83,7 @@ public void onSensorValueChangedFloat(final float[] value) { @Override public void run() { if (canChangeUI()) - x.setText("" + value[0]); + x.setText(String.valueOf(value[0])); } }); y.post(new Runnable() { @@ -91,7 +91,7 @@ public void run() { @Override public void run() { if (canChangeUI()) - y.setText("" + value[1]); + y.setText(String.valueOf(value[1])); } }); z.post(new Runnable() { @@ -99,7 +99,7 @@ public void run() { @Override public void run() { if (canChangeUI()) - z.setText("" + value[2]); + z.setText(String.valueOf(value[2])); } }); diff --git a/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/OrientationFragment.java b/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/OrientationFragment.java index cfc40b6bc..e8a5b96ee 100644 --- a/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/OrientationFragment.java +++ b/oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/OrientationFragment.java @@ -82,7 +82,7 @@ public void onSensorValueChangedFloat(final float[] value) { @Override public void run() { if (canChangeUI()) - x.setText("" + value[0]); + x.setText(String.valueOf(value[0])); } }); y.post(new Runnable() { @@ -90,7 +90,7 @@ public void run() { @Override public void run() { if (canChangeUI()) - y.setText("" + value[1]); + y.setText(String.valueOf(value[1])); } }); z.post(new Runnable() { @@ -98,7 +98,7 @@ public void run() { @Override public void run() { if (canChangeUI()) - z.setText("" + value[2]); + z.setText(String.valueOf(value[2])); } });