🎨 Permission string ids are now appended onto the end of the base permission.

Author: ImBit

API/src/main/java/xyz/bitsquidd/bits/lib/command/BrigadierTreeGenerator.java

@@ -140,7 +140,7 @@ private void processCommandMethod(
         if (!paramBranch.isEmpty()) workingBranch = paramBranch.getLast();
 
         // Add method requirements
-        workingBranch.requires(ctx -> methodInfo.getRequirements().stream()
+        workingBranch.requires(ctx -> methodInfo.getRequirements(commandBuilder.getPermissionString()).stream()
               .allMatch(requirement -> requirement.test(bitsCommandManager.createSourceContext(ctx)))
         );
         workingBranch.executes(createCommandExecution(commandBuilder, methodInfo));

API/src/main/java/xyz/bitsquidd/bits/lib/command/annotation/Permission.java

@@ -9,6 +9,9 @@
 
 /**
  * Specifies an extra string permission to be required to execute the command.
+ * <p>
+ * Note: this is appended onto the end of the base permission string i.e. "bits.command.command_name.permission"
+ * as there are few situations where you should need to share permissions between commands.
  */
 @Target({ElementType.TYPE, ElementType.METHOD})
 @Retention(RetentionPolicy.RUNTIME)

API/src/main/java/xyz/bitsquidd/bits/lib/command/util/BitsCommandBuilder.java

@@ -21,7 +21,7 @@
 import java.util.stream.Stream;
 
 @NullMarked
-public class BitsCommandBuilder {
+public final class BitsCommandBuilder {
     private @Nullable BitsCommand commandInstance;
     private final Class<? extends BitsCommand> commandClass;
 
@@ -107,7 +107,7 @@ public Set<BitsCommandRequirement> getRequirements() {
         Permission permissionAnnotation = commandClass.getAnnotation(Permission.class);
         if (permissionAnnotation != null) {
             requirements.addAll(Arrays.stream(permissionAnnotation.value())
-                  .map(PermissionRequirement::of)
+                  .map(appended -> PermissionRequirement.of(permissionString + "." + appended))
                   .toList());
         }
 
@@ -123,4 +123,8 @@ public Set<BitsCommandRequirement> getRequirements() {
         return requirements;
     }
 
+    public String getPermissionString() {
+        return permissionString;
+    }
+
 }

API/src/main/java/xyz/bitsquidd/bits/lib/command/util/CommandMethodInfo.java

@@ -78,14 +78,14 @@ public String literalName() {
     }
 
     //TODO merge with BitsCommandBuilder permission gathering?
-    public List<BitsCommandRequirement> getRequirements() {
+    public List<BitsCommandRequirement> getRequirements(String permissionString) {
         List<BitsCommandRequirement> requirements = new ArrayList<>();
 
         // Gather permission strings and convert them to requirements.
         Permission permissionAnnotation = method.getAnnotation(Permission.class);
         if (permissionAnnotation != null) {
             requirements.addAll(Arrays.stream(permissionAnnotation.value())
-                  .map(PermissionRequirement::of)
+                  .map(appended -> PermissionRequirement.of(permissionString + "." + appended))
                   .toList());
         }