Skip to content

Commit bf81980

Browse files
committed
Changed json validation in two more files #591
1 parent d9abb82 commit bf81980

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

isatools/convert/isatab2cedar.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,7 @@ def createCEDARjson(self, work_dir, json_dir, inv_identifier):
4141
schema = json.load(json_fp)
4242
if schema is None:
4343
raise IOError("Could not load schema from {}".format(join(CEDAR_SCHEMA_PATH, schema_file)))
44-
resolver = RefResolver("file://{}".format(join(CEDAR_SCHEMA_PATH, schema_file)), schema)
45-
validator = Draft4Validator(schema, resolver=resolver)
44+
validator = Draft4Validator(schema)
4645

4746
isa_tab = isatab_parser.parse(work_dir)
4847

@@ -121,7 +120,7 @@ def createCEDARjson(self, work_dir, json_dir, inv_identifier):
121120
study_identifier = ""
122121

123122
try:
124-
validator.validate(cedar_json, schema)
123+
validator.validate(cedar_json)
125124
except ValidationError as e:
126125
error_file_name = os.path.join(json_dir, "error.log")
127126
with open(error_file_name, "w") as errorfile:

isatools/convert/isatab2json.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,8 @@ def convert(self, work_dir):
140140
# validate json
141141
with open(join(SCHEMAS_PATH, INVESTIGATION_SCHEMA)) as json_fp:
142142
schema = json.load(json_fp)
143-
resolver = RefResolver("file://" + join(SCHEMAS_PATH, INVESTIGATION_SCHEMA), schema)
144-
validator = Draft4Validator(schema, resolver=resolver)
145-
validator.validate(isa_json, schema)
143+
validator = Draft4Validator(schema)
144+
validator.validate(isa_json)
146145

147146
log.info("Conversion finished")
148147
return isa_json

0 commit comments

Comments
 (0)