Fixed Mantis #39962: Reihenfolge der Sortierung ist vertauscht bei Import (#10861)

* Bugfix Export Object Position

* postion in export is required

* change typing position

---------

Co-authored-by: Keven Clausen <[email protected]>

Author: kevenClausenKPG

components/ILIAS/Export/xml/SchemaValidation/ilias_lso_9_0.xsd

@@ -39,6 +39,7 @@
     </xs:sequence>
     <xs:attribute name="obj_id" type="xs:string" use="required"/>
     <xs:attribute name="ref_id" type="xs:string" use="required"/>
+    <xs:attribute name="position" type="xs:string" use="required"/>
   </xs:complexType>
 
   <xs:complexType name="Condition">

components/ILIAS/LearningSequence/classes/Export/class.ilLearningSequenceXMLParser.php

@@ -105,6 +105,7 @@ public function handleBeginTag(
             case Writer::TAG_LSITEM:
                 $this->counter = (int)$attributes["ref_id"];
                 $this->ls_item_data[$this->counter]["ref_id"] = $attributes["ref_id"];
+                $this->ls_item_data[$this->counter]["position"] = $attributes["position"];
                 break;
 
             case Writer::TAG_CONDITION:

components/ILIAS/LearningSequence/classes/Export/class.ilLearningSequenceXMLWriter.php

@@ -115,7 +115,6 @@ protected function writeLPSettings(): void
     protected function writeLSItems(): void
     {
         $this->xmlStartTag(self::TAG_LSITEMS);
-
         $ls_items = $this->ls_object->getLSItems();
         foreach ($ls_items as $ls_item) {
             $post_condition = $ls_item->getPostCondition();
@@ -124,7 +123,8 @@ protected function writeLSItems(): void
                 self::TAG_LSITEM,
                 [
                     'obj_id' => \ilObject::_lookupObjectId($ls_item->getRefId()),
-                    'ref_id' => $ls_item->getRefId()
+                    'ref_id' => $ls_item->getRefId(),
+                    'position' => $ls_item->getOrderNumber()
                 ]
             );
 

components/ILIAS/LearningSequence/classes/class.ilLearningSequenceImporter.php

@@ -109,22 +109,24 @@ protected function buildLSItems(array $ls_data, ilImportMapping $mapping): void
             $mapped[$new_ref_id] = $data;
         }
 
-        $ls_items = $this->obj->getLSItems($this->obj->getRefId());
+        $ls_items = $this->obj->getLSItems();
         $updated = [];
         foreach ($ls_items as $item) {
             $item_ref_id = $item->getRefId();
-            if(array_key_exists($item_ref_id, $mapped)) {
+            if (array_key_exists($item_ref_id, $mapped)) {
                 $item_data = $mapped[$item_ref_id];
                 $post_condition = new ilLSPostCondition(
                     $item_ref_id,
                     $item_data["condition_type"],
                     $item_data["condition_value"]
                 );
-                $updated[] = $item->withPostCondition($post_condition);
+                $item = $item->withPostCondition($post_condition);
+                $item = $item->withOrderNumber((int) $item_data["position"]);
+                $updated[] = $item;
             }
         }
 
-        if($updated) {
+        if ($updated) {
             $this->obj->storeLSItems($updated);
         }
     }