Skip to content

Commit 2526cb1

Browse files
test/tags
Signed-off-by: Laurent Martin <laurent.martin.l@gmail.com>
1 parent d3abeee commit 2526cb1

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

build/lib/test_env.rb

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,12 @@ def configuration
3333
end
3434

3535
# Read and normalize test definitions from tests.yml
36-
# Normalization includes: converting keys to symbols, validating allowed keys, setting defaults,
37-
# extracting plugin names from arguments, and managing tags
36+
# Normalization includes:
37+
# - converting keys to symbols
38+
# - validating allowed keys
39+
# - setting defaults
40+
# - extracting plugin names from arguments
41+
# - managing tags
3842
# @return [Hash{Symbol=>Hash}] Test definitions with normalized structure
3943
def descriptions
4044
tests = Aspera::Yaml.safe_load(Paths::TEST_DEFS.read)

rakelib/test.rake

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -229,9 +229,9 @@ def select_test_cases(selection)
229229
ALL_TESTS.keys
230230
elsif list.first.eql?('tag')
231231
list.shift
232+
list.map!(&:to_sym)
232233
unknown = list - ALL_TESTS.each_with_object(Set.new){ |(_, i), m| m.merge(i[:tags])}.to_a
233234
Aspera.assert(unknown.empty?){"Unknown tag: #{unknown.join(', ')}".red}
234-
list.map!(&:to_sym)
235235
ALL_TESTS.filter_map{ |name, info| name if info[:tags].intersect?(list)}
236236
else
237237
unknown = list - ALL_TESTS.keys
@@ -242,9 +242,8 @@ end
242242

243243
# @return [Integer] Percentage of completed tests
244244
def percent_completed
245-
total = ALL_TESTS.size
246245
completed = STATES.count{ |_, v| SKIP_STATES.include?(v)}
247-
((completed * 100.0) / total).round(1)
246+
((completed * 100.0) / ALL_TESTS.size).round(1)
248247
end
249248

250249
# Set description of target when selectors are available

0 commit comments

Comments
 (0)