Skip to content

epic(trim): clean up trim code #520

@AlessandroPomponio

Description

@AlessandroPomponio

To Do

1. Folder Structure

  • Choose and use a specific folder structure for the TRIM plugin

2. File-Specific Refactoring

plugins/operators/trim/trim/utils/one_dimensional_sampling.py

  • Implement the core logic of the van der Corput inspired sampling with the grey codes

plugins/operators/trim/trim/utils/space_df_connector.py

  • Refactor using better practices (many functions require a lot of locs while doing 'simple things')

3. Pydantic Pattern

  • Use Annotated pattern for pydantic in plugins/operators/trim/trim/no_priors_pydantic.py
  • Fix mutable defaults in the same file

4. Operator-Level Issues

  • Address TODO comment in operator code:
    # TODO: think about a better solution for the fact that the target output may
    # not be acquired for every entity of your space given your experiment.
    # e.g. you want throughput and throughput is only measured for valid runs
    # and some of the runs are not valid
    

5. Build

  • Update pyproject.toml to work correctly with versioning
  • Add meaningful README content

Sub-issues

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions