Oc mirror flow is broken from 4.18 onwards due to minor changes in oc mirror flow

[mohammedzee1000]

It appears that oc mirror flow has been modified slightly in OCP 4.18.
Due to this, the disconnected playbooks need to be modified to account for this change.

The new flow is recorded in

https://docs.openshift.com/container-platform/4.18/disconnected/mirroring/about-installing-oc-mirror-v2.html

Considering that these changes affect 4.18 and above, we need to be careful about fixing this. We would need a if else to ensure both flows are supported for now until we eventually drop the old once 4.17 goes eol.

[mohammedzee1000]

Changes would need to be done in https://github.com/IBM/Ansible-OpenShift-Provisioning/tree/main/roles/disconnected_mirror_images and https://github.com/IBM/Ansible-OpenShift-Provisioning/tree/main/roles/disconnected_apply_operator_manifests_to_cluster

[mohammedzee1000]

One more thing I forgot o mention is oc mirror generates icsp and catalog source for release and operators.l during mirroring op.

It's not possible to apply these during installation so we manually add these (the platform images ones) to install config to ensure platform related icsp is applied and mirrored images are used.

While it's highly unlikely this changed we should verify it and change if needed in all install config templates in the repo which currently support disconnected.

[mohammedzee1000]

for 4.17 and below the docs are https://docs.openshift.com/container-platform/4.17/disconnected/mirroring/installing-mirroring-disconnected.html#oc-mirror-creating-image-set-config_installing-mirroring-disconnected

For 4.18 its https://docs.openshift.com/container-platform/4.18/disconnected/mirroring/about-installing-oc-mirror-v2.html#oc-mirror-building-image-set-config-v2_about-installing-oc-mirror-v2

This should be fixed in https://github.com/IBM/Ansible-OpenShift-Provisioning/blob/main/docs/set-variables-group-vars.md disconnected.mirrroing.oc_mirror.image_set.mirror variable docs to reflect old and new image set

[mohammedzee1000]

#412