diff --git a/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/TimeBasedArchiveRemover.java b/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/TimeBasedArchiveRemover.java index a288034541..9333e24134 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/TimeBasedArchiveRemover.java +++ b/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/TimeBasedArchiveRemover.java @@ -99,6 +99,8 @@ public void cleanPeriod(Instant instantOfPeriodToClean) { File[] matchingFileArray = getFilesInPeriod(instantOfPeriodToClean); for (File f : matchingFileArray) { + LogbackMetrics.getDeletedLogFilesCounter(MAX_HISTORY, fileNamePattern).inc(); + LogbackMetrics.getDeletedLogFileSizeHistogram(MAX_HISTORY, fileNamePattern).update(f.length()); checkAndDeleteFile(f); } @@ -117,10 +119,6 @@ private boolean checkAndDeleteFile(File f) { addWarn("Cannot delete non existent file"); return false; } - - LogbackMetrics.getDeletedLogFilesCounter(MAX_HISTORY, fileNamePattern).inc(); - LogbackMetrics.getDeletedLogFileSizeHistogram(MAX_HISTORY, fileNamePattern).update(f.length()); - boolean result = f.delete(); if (!result) { addWarn("Failed to delete file " + f.toString());