Fix MMO-Items not working when item id contains colon(s). (#194)

BlitzOffline · web-flow · commit 41b2476c9e79 · 2025-05-23T19:31:57.000+01:00
diff --git a/src/main/java/com/extendedclip/deluxemenus/hooks/MMOItemsHook.java b/src/main/java/com/extendedclip/deluxemenus/hooks/MMOItemsHook.java
@@ -35,7 +35,7 @@ public ItemStack getItem(@NotNull final String... arguments) {
             return cached.clone();
         }
 
-        String[] splitArgs = arguments[0].split(":");
+        String[] splitArgs = arguments[0].split(":", 2);
         if (splitArgs.length != 2) {
             return new ItemStack(Material.STONE, 1);
         }
@@ -70,7 +70,7 @@ public boolean itemMatchesIdentifiers(@NotNull ItemStack item, @NotNull String..
         if (arguments.length == 0) {
             return false;
         }
-        String[] splitArgs = arguments[0].split(":");
+        String[] splitArgs = arguments[0].split(":", 2);
         if (splitArgs.length != 2) return false;
         return splitArgs[0].equalsIgnoreCase(MMOItems.getTypeName(item)) && splitArgs[1].equalsIgnoreCase(MMOItems.getID(item));
     }

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public ItemStack getItem(@NotNull final String... arguments) {`
`35`	`35`	`return cached.clone();`
`36`	`36`	`}`
`37`	`37`
`38`		`- String[] splitArgs = arguments[0].split(":");`
	`38`	`+ String[] splitArgs = arguments[0].split(":", 2);`
`39`	`39`	`if (splitArgs.length != 2) {`
`40`	`40`	`return new ItemStack(Material.STONE, 1);`
`41`	`41`	`}`
`@@ -70,7 +70,7 @@ public boolean itemMatchesIdentifiers(@NotNull ItemStack item, @NotNull String..`
`70`	`70`	`if (arguments.length == 0) {`
`71`	`71`	`return false;`
`72`	`72`	`}`
`73`		`- String[] splitArgs = arguments[0].split(":");`
	`73`	`+ String[] splitArgs = arguments[0].split(":", 2);`
`74`	`74`	`if (splitArgs.length != 2) return false;`
`75`	`75`	`return splitArgs[0].equalsIgnoreCase(MMOItems.getTypeName(item)) && splitArgs[1].equalsIgnoreCase(MMOItems.getID(item));`
`76`	`76`	`}`