Merge remote-tracking branch 'origin/sync-02092026'

Author: kriszyp

.git-blame-ignore-revs

@@ -4,3 +4,4 @@
 84de82b25fff81f7b28c1a83789d1a9247fa73b4
 f66b9d9a77db9dfae1d1fe7b764b0a850883df60
 e892d2934b7048b610e4c879fd9b1a523b0004f7
+4e2e8b7980a31086a35c71de8fc8c305393ff771

.oxlintrc.json

@@ -4,6 +4,7 @@
 	"categories": {},
 	"rules": {
 		"no-undef": "error",
+		"no-unused-vars": "error",
 		"no-console": "off",
 		"no-constant-condition": "off",
 		"prefer-const": "off",

CONTRIBUTING.md

@@ -81,7 +81,7 @@ These are the steps @Ethan-Arrowood has been following to synchronize the reposi
 
 ### Last Synchronized Commit
 
-`916492e0bd147b79fd11d3b7bc41902999d64c2b`
+`e69e4b9c0c1c94576d306965c511e9c99efbf00c`
 
 ## Code of Conduct
 

bin/copyDb.ts

@@ -87,7 +87,7 @@ export async function compactOnStart() {
 
 		updateConfigValue(CONFIG_PARAMS.STORAGE_COMPACTONSTART, false);
 
-		for (const [db, { dbPath, backupDest }] of compactedDb) {
+		for (const [_db, { dbPath, backupDest }] of compactedDb) {
 			console.error('Moving backup database', backupDest, 'back to', dbPath);
 			try {
 				await move(backupDest, dbPath, { overwrite: true });
@@ -258,7 +258,7 @@ export async function copyDb(sourceDatabase: string, targetDatabasePath: string)
 						'bytes'
 					);
 					return;
-				} catch (error) {
+				} catch {
 					// try to resume with a bigger key
 					if (typeof start === 'string') {
 						if (start === 'z') {

bin/restart.js

@@ -10,7 +10,6 @@ const { restartWorkers, onMessageByType, shutdownWorkersNow } = require('../serv
 const { handleHDBError, hdbErrors } = require('../utility/errors/hdbError.js');
 const { HTTP_STATUS_CODES } = hdbErrors;
 const envMgr = require('../utility/environment/environmentManager.js');
-const { server } = require('../server/Server.ts');
 const path = require('node:path');
 const { unlinkSync } = require('node:fs');
 envMgr.initSync();

components/Application.ts

@@ -249,7 +249,7 @@ export async function installApplication(application: Application) {
 	// If custom install command is specified, run it
 	if (application.install?.command) {
 		const [command, ...args] = application.install.command.split(' ');
-		const { stderr, code } = await nonInteractiveSpawn(
+		const { stdout, stderr, code } = await nonInteractiveSpawn(
 			application.name,
 			command,
 			args,
@@ -260,8 +260,13 @@ export async function installApplication(application: Application) {
 		if (code === 0) {
 			return;
 		}
-		// otherwise, print the stderr output
-		printStderr(application.name, stderr, 'error');
+		if (stdout) {
+			printStd(application.name, command, stdout, 'stdout', 'warn');
+		}
+
+		if (stderr) {
+			printStd(application.name, command, stderr, 'stderr', 'warn');
+		}
 		// and throw a descriptive error
 		throw new Error(
 			`Failed to install dependencies for ${application.name} using custom install command: ${application.install.command}. Exit code: ${code}`
@@ -300,7 +305,7 @@ export async function installApplication(application: Application) {
 		// Would result in `pnpm@7` being used as the executable.
 		// Important note: an `npm` version should not be specifiable; the only valid npm version is the one installed alongside Node.js
 
-		const { stderr, code } = await nonInteractiveSpawn(
+		const { stdout, stderr, code } = await nonInteractiveSpawn(
 			application.name,
 			packageManager.name,
 			['install'], // All of `npm`, `yarn`, and `pnpm` support the `install` command. If we need to configure options here we may have to use some other defaults though
@@ -315,18 +320,30 @@ export async function installApplication(application: Application) {
 
 		// Otherwise handle failure case based on `onFail` value
 		if (onFail === 'error') {
-			// Log the stderr using the error log level (in case the user doesn't have debug level set)
-			printStderr(packageManager.name, stderr, 'error');
+			// Log the std outputs using the error log level (in case the user doesn't have debug level set)
+			if (stdout) {
+				printStd(application.name, packageManager.name, stdout, 'stdout', 'error');
+			}
+
+			if (stderr) {
+				printStd(application.name, packageManager.name, stderr, 'stderr', 'error');
+			}
+
 			// And throw an error instead of continuing
 			throw new Error(
 				`Failed to install dependencies for ${application.name} using ${packageManager.name}. Exit code: ${code}`
 			);
 		}
 
-		// If onFail is 'warn', print out stderr using the warn level, plus an additional message
+		// If onFail is 'warn', print outputs using the warn level, plus an additional message
 		if (onFail === 'warn') {
-			// Log the stderr using the warn log level
-			printStderr(packageManager.name, stderr, 'warn');
+			if (stdout) {
+				printStd(application.name, packageManager.name, stdout, 'stdout', 'warn');
+			}
+
+			if (stderr) {
+				printStd(application.name, packageManager.name, stderr, 'stderr', 'warn');
+			}
 
 			application.logger.warn(
 				`Failed to install dependencies for ${application.name} using ${packageManager.name}. Exit code: ${code}`
@@ -337,7 +354,7 @@ export async function installApplication(application: Application) {
 	}
 
 	// Finally, default to running `npm install`
-	const { stderr, code } = await nonInteractiveSpawn(
+	const { stdout, stderr, code } = await nonInteractiveSpawn(
 		application.name,
 		'npm',
 		['install', '--force'],
@@ -349,8 +366,14 @@ export async function installApplication(application: Application) {
 		return;
 	}
 
-	// Otherwise, print the stderr output
-	printStderr(application.name, stderr, 'error');
+	// Otherwise, print the stdout and stderr outputs
+	if (stdout) {
+		printStd(application.name, 'npm', stdout, 'stdout', 'warn');
+	}
+
+	if (stderr) {
+		printStd(application.name, 'npm', stderr, 'stderr', 'error');
+	}
 
 	// and throw a descriptive error
 	throw new Error(`Failed to install dependencies for ${application.name} using npm default. Exit code: ${code}`);
@@ -574,15 +597,15 @@ export function nonInteractiveSpawn(
 			clearTimeout(timeout);
 			// Print out stderr before rejecting
 			if (stderr) {
-				printStderr(applicationName, command, stderr);
+				printStd(applicationName, command, stderr, 'stderr');
 			}
 			reject(error);
 		});
 
 		childProcess.on('close', (code) => {
 			clearTimeout(timeout);
 			if (stderr) {
-				printStderr(applicationName, command, stderr);
+				printStd(applicationName, command, stderr, 'stderr');
 			}
 			logger.loggerWithTag(`${applicationName}:spawn:${command}`).debug(`Process exited with code ${code}`);
 			resolve({
@@ -606,15 +629,15 @@ export function getEnvBuiltInComponents() {
 	return builtInComponents;
 }
 
-function printStderr(
+function printStd(
 	applicationName: string,
 	command: string,
-	stderr: string,
+	stdString: string,
+	stdStreamLabel: 'stdout' | 'stderr',
 	level: 'debug' | 'warn' | 'error' = 'debug'
 ) {
-	const stderrLogger = logger.loggerWithTag(`${applicationName}:spawn:${command}:stderr`);
-	for (const line of stderr.split('\n')) {
-		// Intentionally using the `debug` loglevel here since many CLIs, and predominantly package managers use stderr to report progress and metadata.
-		stderrLogger[level](line);
+	const stdLogger = logger.loggerWithTag(`${applicationName}:spawn:${command}:${stdStreamLabel}`);
+	for (const line of stdString.split('\n')) {
+		stdLogger[level](line);
 	}
 }

components/componentLoader.ts

@@ -36,9 +36,7 @@ import { Status } from '../server/status/index.ts';
 import { lifecycle as componentLifecycle } from './status/index.ts';
 import { DEFAULT_CONFIG } from './DEFAULT_CONFIG.ts';
 import { PluginModule } from './PluginModule.ts';
-import { platform } from 'node:os';
 import { getEnvBuiltInComponents } from './Application.ts';
-import { RocksDatabase } from '@harperfast/rocksdb-js';
 
 const CF_ROUTES_DIR = resolvePath(env.get(CONFIG_PARAMS.COMPONENTSROOT));
 let loadedComponents = new Map<any, any>();

components/operations.js

@@ -2,11 +2,9 @@
 
 const path = require('node:path');
 const { isMainThread } = require('node:worker_threads');
-
 const fs = require('fs-extra');
 const fg = require('fast-glob');
 const normalize = require('normalize-path');
-
 const validator = require('./operationsValidation.js');
 const log = require('../utility/logging/harper_logger.js');
 const hdbTerms = require('../utility/hdbTerms.ts');

config/RootConfigWatcher.ts

@@ -40,7 +40,7 @@ export class RootConfigWatcher extends EventEmitter {
 
 				this.emit('change', (this.#config = config));
 			})
-			.catch((error) => {
+			.catch((_error) => {
 				// if yaml parse error ignore?
 			});
 	}

config/configUtils.js

@@ -741,6 +741,7 @@ function getConfiguration() {
 
  */
 async function setConfiguration(setConfigJson) {
+	// eslint-disable-next-line no-unused-vars
 	const { operation, hdb_user, hdbAuthHeader, ...configFields } = setConfigJson;
 	try {
 		updateConfigValue(undefined, undefined, configFields, true);