Skip to content

Commit d1bace0

Browse files
committed
refactor: Optimize common library module[612311]
1 parent 0e9ff9e commit d1bace0

File tree

2 files changed

+6
-35
lines changed

2 files changed

+6
-35
lines changed

TTKCommon/TTKLibrary/ttktime.cpp

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ int TTKObject::random(int value)
2323

2424

2525
TTKTime::TTKTime()
26-
: m_greedyMode(false),
27-
m_defaultType(Entity::Millisecond)
26+
: m_defaultType(Entity::Millisecond)
2827
{
2928
initialize();
3029
}
@@ -112,29 +111,16 @@ qint64 TTKTime::timestamp(bool ms)
112111
return ms ? t : t / 1000;
113112
}
114113

115-
qint64 TTKTime::labelJustifiedToMsecTime(const QString &time)
114+
qint64 TTKTime::formatDuration(const QString &time)
116115
{
117116
const TTKTime t = TTKTime::fromString(time, "mm:ss");
118117
return t.timestamp(Entity::Millisecond);
119118
}
120119

121-
QString TTKTime::msecTimeToLabelJustified()
122-
{
123-
if(!m_greedyMode)
124-
{
125-
return toString("mm:ss");
126-
}
127-
else
128-
{
129-
const int min = m_day * MT_H2S + m_hour * MT_H + m_min;
130-
return QString::number(min).rightJustified(2, '0') + ":" + QString::number(m_sec).rightJustified(2, '0');
131-
}
132-
}
133-
134-
QString TTKTime::msecTimeToLabelJustified(qint64 time, bool greedy)
120+
QString TTKTime::formatDuration(qint64 time/*, bool greedy*/)
135121
{
136122
const TTKTime t(time, Entity::Millisecond);
137-
if(!greedy || time < MT_H2S * MT_S2MS)
123+
if(/*!greedy || */time < MT_H2S * MT_S2MS)
138124
{
139125
return t.toString("mm:ss");
140126
}
@@ -250,7 +236,6 @@ void TTKTime::initialize()
250236

251237
void TTKTime::copyToThis(const TTKTime &other)
252238
{
253-
m_greedyMode = other.m_greedyMode;
254239
m_defaultType = other.m_defaultType;
255240
m_day = other.m_day;
256241
m_hour = other.m_hour;

TTKCommon/TTKLibrary/ttktime.h

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -75,15 +75,6 @@ class TTK_MODULE_EXPORT TTKTime
7575
*/
7676
inline Entity type() const { return m_defaultType; }
7777

78-
/*!
79-
* Set current greedy mode.
80-
*/
81-
inline void setGreedyMode(bool mode) { m_greedyMode = mode; }
82-
/*!
83-
* Get current greedy mode.
84-
*/
85-
inline bool greedyMode() const { return m_greedyMode; }
86-
8778
/*!
8879
* Set current day.
8980
*/
@@ -165,15 +156,11 @@ class TTK_MODULE_EXPORT TTKTime
165156
/*!
166157
* Transform string format(mm:ss) to msec time.
167158
*/
168-
static qint64 labelJustifiedToMsecTime(const QString &time);
169-
/*!
170-
* Transform msec time to string format(mm:ss).
171-
*/
172-
QString msecTimeToLabelJustified();
159+
static qint64 formatDuration(const QString &time);
173160
/*!
174161
* Transform msec time to string format(mm:ss).
175162
*/
176-
static QString msecTimeToLabelJustified(qint64 time, bool greedy = true);
163+
static QString formatDuration(qint64 time/*, bool greedy = true*/);
177164

178165
TTKTime& operator = (const TTKTime &other);
179166
TTKTime& operator+= (const TTKTime &other);
@@ -222,7 +209,6 @@ class TTK_MODULE_EXPORT TTKTime
222209
*/
223210
void fromTimeStamp(qint64 value, int delta);
224211

225-
bool m_greedyMode;
226212
Entity m_defaultType;
227213
int m_day, m_hour;
228214
int m_min, m_sec, m_msec;

0 commit comments

Comments
 (0)