fix(ChromeDriver,ChromeDriverDragAndDropIntegrationTests): fixed drag and drop chromedriver method; method throws an error when trying draggable attribute not set

Author: vimscientist69

Sources/SwiftWebDriver/API/Request/Elements/PostElementDragAndDropRequest.swift

@@ -36,14 +36,10 @@ internal struct PostElementDragAndDropRequest: RequestType {
         let origin = WebDriverElementOrigin(element: elementId)
         let dragToOrigin = WebDriverElementOrigin(element: toElementId)
 
-        // let sourceCenterX = Int(elementRect.width / 2)
-        // let sourceCenterY = Int(elementRect.height / 2)
-        //
         let targetCenterX = Int(targetElementRect.width / 2)
         let targetCenterY = Int(targetElementRect.height / 2)
 
         let pointerActions = [
-            // PointerAction(type: "pointerMove", origin: origin, x: sourceCenterX, y: sourceCenterY),
             PointerAction(type: "pointerMove", origin: origin, x: 0, y: 0),
             PointerAction(type: "pointerDown", button: 0),
             PointerAction(type: "pause", duration: 100),

Sources/SwiftWebDriver/WebDrivers/Chrome/ChromeDriverElementDragAndDropper.swift

@@ -58,7 +58,11 @@ internal struct ChromeDriverElementDragAndDropper {
     }
 
     private func isHTML5Draggable() async throws -> Bool {
-        let draggableValue = try await source.attribute(name: "draggable")
+        guard
+            let draggableValue = try? await source.attribute(name: "draggable")
+        else {
+            return false
+        }
         return draggableValue.lowercased() == "true"
     }
 }

Tests/SwiftWebDriverIntegrationTests/ChromeDriver/Element/ChromeDriverDragAndDropIntegrationTests.swift

@@ -8,9 +8,19 @@ import Testing
 
 @Suite("Chrome Driver Drag and Drop Integration Tests", .serialized)
 internal class ChromeDriverDragAndDropIntegrationTests: ChromeDriverTest {
-    @Test("Drag Element To Another")
-    func dragAndDropElementToAnother() async throws {
+    @Test("Drag Element To Another (JavaScript)")
+    func dragAndDropElementToAnotherWithDraggableElement() async throws {
         page = "dragTarget.html"
+        try await dragAndDrop()
+    }
+
+    @Test("Drag Element To Another (WebDriver Actions API)")
+    func dragAndDropElementToAnother() async throws {
+        page = "dragBox.html"
+        try await dragAndDrop()
+    }
+
+    private func dragAndDrop() async throws {
         try await driver.navigateTo(urlString: testPageURL.absoluteString)
 
         let sourceElement = try await driver.findElement(.css(.id("source")))
@@ -24,24 +34,5 @@ internal class ChromeDriverDragAndDropIntegrationTests: ChromeDriverTest {
         #expect(targetElementText == "DROPPED!")
     }
 
-    @Test("Set Property")
-    func setProperty() async throws {
-        page = "elementHandleTestPage.html"
-        try await driver.navigateTo(urlString: testPageURL.absoluteString)
-        let element = try await driver.findElement(.css(.id("setproperty")))
-        let newPropertyValue = "element new inner text"
-
-        try await driver.setProperty(element: element, propertyName: "innerText", newValue: newPropertyValue)
-        guard
-            let elementInnerTextValue = try await driver.getProperty(element: element, propertyName: "innerText").value?
-            .stringValue
-        else {
-            #expect(Bool(false), "Could not convert element innerText value to string value")
-            return
-        }
-
-        #expect(newPropertyValue == elementInnerTextValue)
-    }
-
     deinit {}
 }