fix: support Pipenv develop packages without a version (#186)

G-Rath · web-flow · commit 8bc880ecc5ba · 2023-04-28T07:56:36.000+12:00
diff --git a/pkg/lockfile/fixtures/pipenv/no-version.json b/pkg/lockfile/fixtures/pipenv/no-version.json
@@ -22,5 +22,11 @@
       "ref": "b36054111bc1e8bbadb5d0d60158feb72926f467"
     }
   },
-  "develop": {}
+  "develop": {
+    "itsdangerous": {
+      "editable": true,
+      "git": "https://github.com/pallets/itsdangerous",
+      "ref": "de09cad488a4d7c7bbcbcdb8e1c2dfde64325f48"
+    }
+  }
 }
diff --git a/pkg/lockfile/parse-pipenv-lock.go b/pkg/lockfile/parse-pipenv-lock.go
@@ -50,6 +50,10 @@ func ParsePipenvLock(pathToLockfile string) ([]PackageDetails, error) {
 	}
 
 	for name, pipenvPackage := range parsedLockfile.PackagesDev {
+		if pipenvPackage.Version == "" {
+			continue
+		}
+
 		version := pipenvPackage.Version[2:]
 
 		packages[name+"@"+version] = PackageDetails{

Original file line number	Diff line number	Diff line change
`@@ -22,5 +22,11 @@`
`22`	`22`	`"ref": "b36054111bc1e8bbadb5d0d60158feb72926f467"`
`23`	`23`	`}`
`24`	`24`	`},`
`25`		`- "develop": {}`
	`25`	`+ "develop": {`
	`26`	`+ "itsdangerous": {`
	`27`	`+ "editable": true,`
	`28`	`+ "git": "https://github.com/pallets/itsdangerous",`
	`29`	`+ "ref": "de09cad488a4d7c7bbcbcdb8e1c2dfde64325f48"`
	`30`	`+ }`
	`31`	`+ }`
`26`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,10 @@ func ParsePipenvLock(pathToLockfile string) ([]PackageDetails, error) {`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`for name, pipenvPackage := range parsedLockfile.PackagesDev {`
	`53`	`+ if pipenvPackage.Version == "" {`
	`54`	`+ continue`
	`55`	`+ }`
	`56`	`+`
`53`	`57`	`version := pipenvPackage.Version[2:]`
`54`	`58`
`55`	`59`	`packages[name+"@"+version] = PackageDetails{`