November 28th, 2025 Update

Author: FrogAi

frogpilot/assets/other_images/weather_clear_day.gif

@@ -33,13 +33,13 @@ def __init__(self, CP, FPCP):
   def handle_button_event(self, sm, frogpilot_toggles, key):
     if sm["carControl"].longActive and getattr(frogpilot_toggles, f"experimental_mode_via_{key}"):
       self.handle_experimental_mode(sm, frogpilot_toggles)
-    elif sm["carControl"].longActive and getattr(frogpilot_toggles, f"force_coast_via{key}"):
+    elif sm["carControl"].longActive and getattr(frogpilot_toggles, f"force_coast_via_{key}"):
       self.force_coast = not self.force_coast
-    elif getattr(frogpilot_toggles, f"pause_lateral_via{key}"):
+    elif getattr(frogpilot_toggles, f"pause_lateral_via_{key}"):
       self.pause_lateral = not self.pause_lateral
-    elif sm["carControl"].longActive and getattr(frogpilot_toggles, f"pause_longitudinal_via{key}"):
+    elif sm["carControl"].longActive and getattr(frogpilot_toggles, f"pause_longitudinal_via_{key}"):
       self.pause_longitudinal = not self.pause_longitudinal
-    elif getattr(frogpilot_toggles, f"traffic_mode_via{key}"):
+    elif getattr(frogpilot_toggles, f"traffic_mode_via_{key}"):
       self.traffic_mode_enabled = not self.traffic_mode_enabled
 
   def handle_experimental_mode(self, sm, frogpilot_toggles):

frogpilot/assets/other_images/weather_clear_night.gif

@@ -153,7 +153,8 @@ def make_request():
         try:
           self.api_3_calls += 1
           response = self.session.get("https://api.openweathermap.org/data/3.0/onecall", params=params, timeout=10)
-          if response.status_code == 429:
+
+          if response.status_code in (401, 403, 429):
             fallback_params = params.copy()
             fallback_params.pop("exclude", None)
             self.api_25_calls += 1

frogpilot/assets/other_images/weather_low_visibility.gif

@@ -58,9 +58,9 @@ def frogpilot_thread():
                             "frogpilotSelfdriveState", "frogpilotModelV2", "frogpilotOnroadEvents"],
                             poll="modelV2")
 
-  params = Params()
-  params_cache = Params(cache=True)
-  params_memory = Params(memory=True)
+  params = Params(return_defaults=True)
+  params_cache = Params(cache=True, return_defaults=True)
+  params_memory = Params(memory=True, return_defaults=True)
 
   frogpilot_variables = FrogPilotVariables()
   theme_manager = ThemeManager(params, params_memory)

frogpilot/assets/other_images/weather_rain.gif

@@ -434,27 +434,44 @@ FrogPilotLongitudinalPanel::FrogPilotLongitudinalPanel(FrogPilotSettingsWindow *
               weatherKeyControl->setVisibleButton(1, true);
             }
           }
-        } else {
+        } else if (id == 1) {
           weatherKeyControl->setValue(tr("Testing..."));
 
-          QString key = QString::fromStdString(params.get("WeatherToken"));
-          QString url = QString("https://api.openweathermap.org/data/2.5/weather?lat=42.4293&lon=-83.9850&appid=%1").arg(key);
+          QString key = QString::fromStdString(params.get("WeatherToken")).trimmed();
+          QString url30 = QString("https://api.openweathermap.org/data/3.0/onecall?lat=42.4293&lon=-83.9850&exclude=current,minutely,hourly,daily,alerts&appid=%1").arg(key);
 
-          QNetworkRequest request(url);
+          QNetworkRequest request(url30);
           QNetworkReply *reply = networkManager->get(request);
-          connect(reply, &QNetworkReply::finished, [=]() {
-            weatherKeyControl->setValue("");
+          QObject::connect(reply, &QNetworkReply::finished, this, [=]() {
+            reply->deleteLater();
 
-            QString message;
             if (reply->error() == QNetworkReply::NoError) {
-              message = tr("Key is valid!");
-            } else if (reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt() == 401) {
-              message = tr("Invalid key!");
+              weatherKeyControl->setValue("");
+              ConfirmationDialog::alert(tr("Key is valid!"), this);
+              return;
+            }
+
+            int status = reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt();
+            if (status == 401 || status == 403) {
+              QString url25 = QString("https://api.openweathermap.org/data/2.5/weather?lat=42.4293&lon=-83.9850&appid=%1").arg(key);
+
+              QNetworkRequest request25(url25);
+              QNetworkReply *reply25 = networkManager->get(request25);
+              QObject::connect(reply25, &QNetworkReply::finished, this, [=]() {
+                reply25->deleteLater();
+
+                weatherKeyControl->setValue("");
+                if (reply25->error() == QNetworkReply::NoError) {
+                  ConfirmationDialog::alert(tr("Your key is valid for version 2.5, but version 3.0 is highly recommended! Please subscribe to the \"One Call API 3.0\" plan!"), this);
+                } else {
+                   int status25 = reply25->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt();
+                   ConfirmationDialog::alert(tr("Invalid key! (Error: %1)").arg(status25), this);
+                }
+              });
             } else {
-              message = tr("An error occurred: %1").arg(reply->errorString());
+              weatherKeyControl->setValue("");
+              ConfirmationDialog::alert(tr("An error occurred: %1").arg(reply->errorString()), this);
             }
-            ConfirmationDialog::alert(message, this);
-            reply->deleteLater();
           });
         }
       });