Make safer

Author: hardillb

lib/agent.js

@@ -281,16 +281,18 @@ class Agent {
         if (this.launcher?.readPackage) {
             if (!this.config.moduleCache) {
                 const { modules } = this.launcher.readPackage()
-                if (semver.valid(modules['node-red']) !== null) {
-                    state.nodeRedVersion = modules['node-red']
-                } else {
-                    try {
-                        const nrPackPath = path.join(this.launcher.projectDir, 'node_modules/node-red/package.json')
-                        const content = readFileSync(nrPackPath)
-                        const packJSON = JSON.parse(content)
-                        state.nodeRedVersion = packJSON.version
-                    } catch (err) {
-                        // Bad node-red install
+                if (modules) {
+                    if (semver.valid(modules['node-red']) !== null) {
+                        state.nodeRedVersion = modules['node-red']
+                    } else {
+                        try {
+                            const nrPackPath = path.join(this.launcher.projectDir, 'node_modules/node-red/package.json')
+                            const content = readFileSync(nrPackPath)
+                            const packJSON = JSON.parse(content)
+                            state.nodeRedVersion = packJSON.version
+                        } catch (err) {
+                            // Bad node-red install
+                        }
                     }
                 }
             } else {

test/unit/lib/agent_spec.js

@@ -606,10 +606,10 @@ describe('Agent', function () {
             agent.launcher = Launcher.newLauncher()
             agent.launcher.reportPackages = true
             await agent.start()
-            await agent.suspendNR()
-            // const state = agent.getState()
+            const state = agent.getState()
             // readPackage requires running launcher, but that requires installing packages
             // to read versions from
+            state.should.have.property('mode')
         })
     })