Skip to content

Commit 13cfb2f

Browse files
committed
fix: pin pip dependencies
Installing dependencies via pip implicitly uses "latest". In this case, "latest" for robotframework broke our tests due to a bug introduced in version 7.4. Generally, dependencies shall be pinned. Otherwise, all hell breaks loose.
1 parent 848166b commit 13cfb2f

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

layers/base/Dockerfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,9 @@ ENV VIRTUAL_ENV=/build/venv
143143
RUN python3 -m venv $VIRTUAL_ENV
144144
ENV PATH="$VIRTUAL_ENV/bin:$PATH"
145145

146-
RUN pip install mypy pep8 pylint pytest pytest-cov robotframework
146+
COPY requirements.txt /tmp/requirements.txt
147+
148+
RUN pip install -r /tmp/requirements.txt
147149

148150
# Ensure venv owner
149151
USER root

layers/base/requirements.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
mypy==1.19.1
2+
pep8==1.7.1
3+
pylint==4.0.4
4+
pytest==9.0.2
5+
pytest-cov==7.0.0
6+
robotframework==7.3.2 ## WARNING: 7.4 has a bug which breaks our tests

0 commit comments

Comments
 (0)