Skip to content

Commit 997cbf5

Browse files
authored
Merge pull request #30 from ElcanoTek/codex/fix-victoria.py-running-in-dev-mode
2 parents a2f2f88 + 5172706 commit 997cbf5

File tree

3 files changed

+7
-15
lines changed

3 files changed

+7
-15
lines changed

README.md

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -83,25 +83,19 @@ Victoria is Elcano's AI agent that connects to programmatic advertising reports
8383

8484
## 🚀 Launching Victoria
8585

86-
Open your terminal, change into the `victoria-crush` folder, and run:
86+
Open your terminal, change into the `victoria-crush` folder, and run in developer mode:
8787

8888
```bash
8989
cd /path/to/victoria-crush
90-
python3 victoria.py
90+
python3 victoria.py --dev
9191
```
9292

9393
This gives you the most control and is the same across macOS, Linux, and Windows (PowerShell).
9494
All modes store configuration and data in `~/Victoria` (or `%USERPROFILE%\Victoria` on Windows).
9595

96-
To refresh the bundled `VICTORIA.md` knowledge base during development, run:
97-
98-
```bash
99-
python3 victoria.py --dev
100-
```
101-
102-
You can also enable developer mode by setting `VICTORIA_DEV=1` in your
103-
environment. Packaged builds ignore this variable to avoid shipping in
104-
developer mode; use the `--dev` flag explicitly if needed.
96+
We recommend always using the `--dev` flag when running from the command line to keep your
97+
`VICTORIA.md` knowledge base up to date. Packaged builds run without developer prompts unless
98+
you pass `--dev` explicitly.
10599

106100
#### Customizing the launch tool
107101

tests/test_victoria.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ def test_environment_variables():
190190

191191
print("✅ Environment variable tests passed")
192192
return True
193-
193+
194194
except Exception as e:
195195
print(f"✗ Environment variable error: {e}")
196196
return False

victoria.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -712,9 +712,7 @@ def open_victoria_folder():
712712

713713
def main():
714714
args = parse_args()
715-
dev_mode = args.dev or (
716-
os.environ.get("VICTORIA_DEV") == "1" and not getattr(sys, "frozen", False)
717-
)
715+
dev_mode = args.dev
718716

719717
ensure_default_files()
720718
clear_screen()

0 commit comments

Comments
 (0)