Merge pull request #20 from ElcanoTek/codex/fix-app-bundling-in-mac-os

Ignore VICTORIA_DEV in packaged app

Author: bradflaugher

README.md

@@ -99,6 +99,10 @@ To refresh the bundled `VICTORIA.md` knowledge base during development, run:
 python3 victoria.py --dev
 ```
 
+You can also enable developer mode by setting `VICTORIA_DEV=1` in your
+environment. Packaged builds ignore this variable to avoid shipping in
+developer mode; use the `--dev` flag explicitly if needed.
+
 #### Customizing the launch tool
 
 Victoria uses the `crush` CLI by default. Set the following environment variables to swap in a different tool or config files:
@@ -111,7 +115,8 @@ export VICTORIA_OUTPUT="your_cli.json"
 
 ## 📦 Packaging for macOS and Windows
 
-You can build standalone packages so Victoria can be launched from Finder. The macOS app opens a terminal window for interaction.
+You can build standalone packages so Victoria can be launched from Finder. The macOS app opens a terminal window for interaction
+and detects existing sessions to avoid spawning extra Terminal windows.
 
 ### macOS `.app`
 

package_mac.sh

@@ -27,6 +27,10 @@ chmod +x "$MACOS/launch.command"
 cat > "$MACOS/Victoria" <<'EOF'
 #!/bin/bash
 DIR="$(cd "$(dirname "$0")" && pwd)"
-open -a Terminal "$DIR/launch.command"
+if [ -n "$TERM_PROGRAM" ]; then
+  "$DIR/launch.command"
+else
+  open -a Terminal "$DIR/launch.command"
+fi
 EOF
 chmod +x "$MACOS/Victoria"

victoria.py

@@ -712,7 +712,9 @@ def open_victoria_folder():
 
 def main():
     args = parse_args()
-    dev_mode = args.dev or os.environ.get("VICTORIA_DEV") == "1"
+    dev_mode = args.dev or (
+        os.environ.get("VICTORIA_DEV") == "1" and not getattr(sys, "frozen", False)
+    )
 
     ensure_default_files()
     clear_screen()