BUILD: Testsuite looks for release libdrx.so in lib64/release on debug builds

[palmer-dabbelt]

Describe the bug
I'm trying to build the test suite in a build directory that has only ever contained a debug build, and it's looking for release libraries. Specifically

20: make[2]: *** No rule to make target '/home/palmerdabbelt/dynamorio/build/ext/lib64/release/libdrx.so', needed by 'bin/libopcodes.so'.  Stop.

To Reproduce

1. Start with a clean build directory.
2. Configure a debug build.
3. make check

Expected behavior
Debug builds from a clean build directory can pass the test suite.

Screenshots or Pasted Text

        Start  20: samples_proj

20: Test command: /usr/bin/ctest "--build-and-test" "/home/palmerdabbelt/dynamorio/build/api/samples" "/home/palmerdabbelt/dynamorio/build/api/samples/build_and_test" "--build-generator" "Unix Makefiles" "--build-project" "DynamoRIO_samples" "--build-makeprogram" "/usr/bin/make" "--build-options" "-DDEBUG=ON" "-DDynamoRIO_DIR:PATH=/home/palmerdabbelt/dynamorio/build/cmake"
20: Test timeout computed to be: 1500
20: Internal cmake changing into directory: /home/palmerdabbelt/dynamorio/build/api/samples/build_and_test
20: ======== CMake output     ======
20: The C compiler identification is GNU 9.4.0
20: The CXX compiler identification is GNU 9.4.0
20: Check for working C compiler: /usr/bin/cc
20: Check for working C compiler: /usr/bin/cc -- works
20: Detecting C compiler ABI info
20: Detecting C compiler ABI info - done
20: Detecting C compile features
20: Detecting C compile features - done
20: Check for working CXX compiler: /usr/bin/c++
20: Check for working CXX compiler: /usr/bin/c++ -- works
20: Detecting CXX compiler ABI info
20: Detecting CXX compiler ABI info - done
20: Detecting CXX compile features
20: Detecting CXX compile features - done
20: Configuring done
20: Generating done
20: Build files have been written to: /home/palmerdabbelt/dynamorio/build/api/samples/build_and_test
20: ======== End CMake output ======
20: Change Dir: /home/palmerdabbelt/dynamorio/build/api/samples/build_and_test
20: 
20: Run Clean Command:/usr/bin/make clean
20: 
20: Run Build Command(s):/usr/bin/make && Scanning dependencies of target opcodes
20: [  2%] Building C object CMakeFiles/opcodes.dir/opcodes.c.o
20: make[2]: *** No rule to make target '/home/palmerdabbelt/dynamorio/build/ext/lib64/release/libdrx.so', needed by 'bin/libopcodes.so'.  Stop.
20: make[1]: *** [CMakeFiles/Makefile2:114: CMakeFiles/opcodes.dir/all] Error 2
20: make: *** [Makefile:84: all] Error 2
20: 
 20/437 Test  #20: samples_proj .....................................................***Failed    0.74 sec

Versions
This happens on the latest master 0494778 ("i#5365 AArch64 tests: fix drcacheoff.scale_time test for Ubuntu 24.04 (#7761)"), but I think it's been happening for a while.

[ivankyluk]

Did you do "make" under build after "cmake", and before "ctest"?

I see a similar problem if I run "make clean" and "ctest -R samples_proj" without running "make" before ctest:

Run Build Command(s): /usr/bin/gmake -f Makefile
[ 1%] Building C object CMakeFiles/bbbuf.dir/bbbuf.c.o
gmake[2]: *** No rule to make target '/usr/local/google/home/kyluk/drsyscall/dynamorio/build/ext/lib64/debug/libdrx.so', needed by 'bin/libbbbuf.so'. Stop.
gmake[1]: *** [CMakeFiles/Makefile2:183: CMakeFiles/bbbuf.dir/all] Error 2
gmake: *** [Makefile:91: all] Error 2

[palmer-dabbelt]

Did you do "make" under build after "cmake", and before "ctest"?

Yes, and as far as I can tell themake seem to be happy.

I see a similar problem if I run "make clean" and "ctest -R samples_proj" without running "make" before ctest:

Run Build Command(s): /usr/bin/gmake -f Makefile [ 1%] Building C object CMakeFiles/bbbuf.dir/bbbuf.c.o gmake[2]: *** No rule to make target '/usr/local/google/home/kyluk/drsyscall/dynamorio/build/ext/lib64/debug/libdrx.so', needed by 'bin/libbbbuf.so'. Stop. gmake[1]: *** [CMakeFiles/Makefile2:183: CMakeFiles/bbbuf.dir/all] Error 2 gmake: *** [Makefile:91: all] Error 2

OK, I don't know the DynamoRIO build system very well but I'd generally be kind of surprised if anything works right without running make before ctest -- at least that's the case in other project I've worked on. I think that's different than what I'm seeing though, I'm pretty sure I've just got a release/debug mismatch in some path mangling script somewhere...

[palmer-dabbelt]

If it helps any, I also see this on drmemtrace_proj with libdrmemtrace_analyzer.a. I'd guess it's the same root cause.

        Start  22: drmemtrace_proj

22: Test command: /usr/bin/ctest "--build-and-test" "/home/palmerdabbelt/work/dynamorio/clients/drcachesim/tests" "/home/palmerdabbelt/work/dynamorio/build/clients/drcachesim/tests/build_and_test" "--build-generator" "Unix Makefiles" "--build-project" "DynamoRIO_drmemtrace" "--build-makeprogram" "/usr/bin/gmake" "--build-options" "-DCMAKE_BUILD_TYPE=Debug" "-DDEBUG=ON" "-DDynamoRIO_DIR:PATH=/home/palmerdabbelt/work/dynamorio/build/cmake"
22: Working Directory: /home/palmerdabbelt/work/dynamorio/build/suite/tests
22: Test timeout computed to be: 1500
22: Internal cmake changing into directory: /home/palmerdabbelt/work/dynamorio/build/clients/drcachesim/tests/build_and_test
22: ======== CMake output     ======
22: Configuring done (0.0s)
22: Generating done (0.0s)
22: Build files have been written to: /home/palmerdabbelt/work/dynamorio/build/clients/drcachesim/tests/build_and_test
22: ======== End CMake output ======
22: Change Dir: /home/palmerdabbelt/work/dynamorio/build/clients/drcachesim/tests/build_and_test
22:
22: Run Clean Command:/usr/bin/gmake -f Makefile clean
22:
22: Run Build Command(s):/usr/bin/gmake -f Makefile && [ 25%] Building CXX object CMakeFiles/analyzer_separate.dir/analyzer_separate.cpp.o
22: gmake[2]: *** No rule to make target '/home/palmerdabbelt/work/dynamorio/build/clients/lib64/release/libdrmemtrace_analyzer.a', needed by 'analyzer_separate'.  Stop.
22: gmake[1]: *** [CMakeFiles/Makefile2:85: CMakeFiles/analyzer_separate.dir/all] Error 2
22: gmake: *** [Makefile:91: all] Error 2
22:
 22/432 Test  #22: drmemtrace_proj ..................................................***Failed    0.66 sec

[derekbruening]

You can see this does not reproduce in the automated tests, which also test a debug build with the UNIX Makefiles generator and the samples_proj test passes: https://github.com/DynamoRIO/dynamorio/actions/runs/20764247042/job/59626608516#step:12:25691

239/426 Test  #19: samples_proj .....................................................   Passed   10.63 sec

It also passes in my local build dir, which is debug build but with ninja generator:

$ ninja && ctest -R samples_proj
...
1/1 Test #27: samples_proj .....................   Passed    2.64 sec

What were the exact configure and build commands you used?

[palmer-dabbelt]

I just did a clean build/test run to double check, here's what I ran:

git clone https://github.com/DynamoRIO/dynamorio.git
cd dynamorio/
git submodule update --init --recursive
mkdir build
cd build/
cmake -DBUILD_TESTS=On -DDEBUG=On ..
make -j16
ctest -VV |& tee ctest-VV.log

[ivankyluk]

I followed the steps above and samples_proj passed. Comparing the logs, I don't see "Looking for libunwind.h" in your log. Here's the log of my local test:

        Start  27: samples_proj

27: Test command: /usr/bin/ctest "--build-and-test" "/usr/local/google/home/kyluk/dynamorio_test/dynamorio/build/api/samples" "/usr/local/google/home/kyluk/dynamorio_test/dynamorio/build/api/samples/build_and_test" "--build-generator" "Unix Makefiles" "--build-project" "DynamoRIO_samples" "--build-makeprogram" "/usr/bin/gmake" "--build-options" "-DDEBUG=ON" "-DDynamoRIO_DIR:PATH=/usr/local/google/home/kyluk/dynamorio_test/dynamorio/build/cmake"
27: Working Directory: /usr/local/google/home/kyluk/dynamorio_test/dynamorio/build/suite/tests
27: Test timeout computed to be: 1500
27: Internal cmake changing into directory: /usr/local/google/home/kyluk/dynamorio_test/dynamorio/build/api/samples/build_and_test
27: ======== CMake output     ======
27: The C compiler identification is GNU 14.2.0
27: The CXX compiler identification is GNU 14.2.0
27: Detecting C compiler ABI info
27: Detecting C compiler ABI info - done
27: Check for working C compiler: /usr/bin/cc - skipped
27: Detecting C compile features
27: Detecting C compile features - done
27: Detecting CXX compiler ABI info
27: Detecting CXX compiler ABI info - done
27: Check for working CXX compiler: /usr/bin/c++ - skipped
27: Detecting CXX compile features
27: Detecting CXX compile features - done
27: Looking for libunwind.h                                       <<<<
27: Looking for libunwind.h - found                          <<<<
27: Configuring done (1.2s)
27: Generating done (0.1s)
: 
27/560 Test  #27: samples_proj .......................................................   Passed    9.58 sec

Can you tell us more about the OS you are running the test on?

[jackgallagher-arm]

I just did a clean build/test run to double check, here's what I ran:

git clone https://github.com/DynamoRIO/dynamorio.git
cd dynamorio/
git submodule update --init --recursive
mkdir build
cd build/
cmake -DBUILD_TESTS=On -DDEBUG=On ..
make -j16
ctest -VV |& tee ctest-VV.log

I haven't been able to reproduce the error when following these instructions but I have seen this error if you configure a build for release (the default configuration) then reconfigure it for debug:

$ git clone https://github.com/DynamoRIO/dynamorio.git
$ cd dynamorio/
$ git submodule update --init --recursive
$ mkdir build
$ cd build/
$ cmake -DBUILD_TESTS=On .. # Defaults to DEBUG=Off
$ cmake -DBUILD_TESTS=On -DDEBUG=On .. # Whoops I wanted DEBUG=On
$ make -j16
$ ctest -VV -R proj
UpdateCTestConfiguration  from :/path/to/dynamorio/build/DartConfiguration.tcl
Parse Config file:/path/to/dynamorio/build/DartConfiguration.tcl
UpdateCTestConfiguration  from :/path/to/dynamorio/build/DartConfiguration.tcl
Parse Config file:/path/to/dynamorio/build/DartConfiguration.tcl
Test project /path/to/dynamorio/build
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 20
    Start 20: samples_proj

20: Test command: /usr/bin/ctest "--build-and-test" "/path/to/dynamorio/build/api/samples" "/path/to/dynamorio/build/api/samples/build_and_test" "--build-generator" "Unix Makefiles" "--build-project" "DynamoRIO_samples" "--build-makeprogram" "/usr/bin/make" "--build-options" "-DDEBUG=ON" "-DDynamoRIO_DIR:PATH=/path/to/dynamorio/build/cmake"
20: Test timeout computed to be: 1500
20: Internal cmake changing into directory: /path/to/dynamorio/build/api/samples/build_and_test
20: ======== CMake output     ======
20: The C compiler identification is GNU 11.4.0
20: The CXX compiler identification is GNU 11.4.0
20: Check for working C compiler: /usr/bin/cc
20: Check for working C compiler: /usr/bin/cc -- works
20: Detecting C compiler ABI info
20: Detecting C compiler ABI info - done
20: Detecting C compile features
20: Detecting C compile features - done
20: Check for working CXX compiler: /usr/bin/c++
20: Check for working CXX compiler: /usr/bin/c++ -- works
20: Detecting CXX compiler ABI info
20: Detecting CXX compiler ABI info - done
20: Detecting CXX compile features
20: Detecting CXX compile features - done
20: Configuring done
20: Generating done
20: Build files have been written to: /path/to/dynamorio/build/api/samples/build_and_test
20: ======== End CMake output ======
20: Change Dir: /path/to/dynamorio/build/api/samples/build_and_test
20: 
20: Run Clean Command:/usr/bin/make clean
20: 
20: Run Build Command(s):/usr/bin/make && Scanning dependencies of target opcodes
20: [  2%] Building C object CMakeFiles/opcodes.dir/opcodes.c.o
20: make[2]: *** No rule to make target '/path/to/dynamorio/build/ext/lib64/release/libdrx.so', needed by 'bin/libopcodes.so'.  Stop.
20: make[1]: *** [CMakeFiles/Makefile2:114: CMakeFiles/opcodes.dir/all] Error 2
20: make: *** [Makefile:84: all] Error 2
20: 
1/2 Test #20: samples_proj .....................***Failed    0.91 sec
test 22
    Start 22: drmemtrace_proj

22: Test command: /usr/bin/ctest "--build-and-test" "/path/to/dynamorio/clients/drcachesim/tests" "/path/to/dynamorio/build/clients/drcachesim/tests/build_and_test" "--build-generator" "Unix Makefiles" "--build-project" "DynamoRIO_drmemtrace" "--build-makeprogram" "/usr/bin/make" "--build-options" "-DCMAKE_BUILD_TYPE=Debug" "-DDEBUG=ON" "-DDynamoRIO_DIR:PATH=/path/to/dynamorio/build/cmake"
22: Test timeout computed to be: 1500
22: Internal cmake changing into directory: /path/to/dynamorio/build/clients/drcachesim/tests/build_and_test
22: ======== CMake output     ======
22: The C compiler identification is GNU 11.4.0
22: The CXX compiler identification is GNU 11.4.0
22: Check for working C compiler: /usr/bin/cc
22: Check for working C compiler: /usr/bin/cc -- works
22: Detecting C compiler ABI info
22: Detecting C compiler ABI info - done
22: Detecting C compile features
22: Detecting C compile features - done
22: Check for working CXX compiler: /usr/bin/c++
22: Check for working CXX compiler: /usr/bin/c++ -- works
22: Detecting CXX compiler ABI info
22: Detecting CXX compiler ABI info - done
22: Detecting CXX compile features
22: Detecting CXX compile features - done
22: Found ZLIB: /usr/lib/aarch64-linux-gnu/libz.so (found version "1.2.11") 
22: Configuring done
22: Generating done
22: Build files have been written to: /path/to/dynamorio/build/clients/drcachesim/tests/build_and_test
22: ======== End CMake output ======
22: Change Dir: /path/to/dynamorio/build/clients/drcachesim/tests/build_and_test
22: 
22: Run Clean Command:/usr/bin/make clean
22: 
22: Run Build Command(s):/usr/bin/make && Scanning dependencies of target burst_separate
22: [ 25%] Building CXX object CMakeFiles/burst_separate.dir/burst_static.cpp.o
22: make[2]: *** No rule to make target '/path/to/dynamorio/build/lib64/release/libdynamorio_static.a', needed by 'burst_separate'.  Stop.
22: make[1]: *** [CMakeFiles/Makefile2:78: CMakeFiles/burst_separate.dir/all] Error 2
22: make: *** [Makefile:84: all] Error 2
22: 
2/2 Test #22: drmemtrace_proj ..................***Failed    0.80 sec

0% tests passed, 2 tests failed out of 2

Total Test time (real) =   1.90 sec

The following tests FAILED:
	 20 - samples_proj (Failed)
	 22 - drmemtrace_proj (Failed)
Errors while running CTest

Could that be what has happened here?