Skip to content

Commit d1a742a

Browse files
jchaffraixcpeel
authored andcommitted
Upgrade PHPStan to 1.12.12
PHPStan was upgraded to 2.0 in November, but we're not ready to upgrade as it detects a lot of new errors. That said our first step is to upgrade to the latest 1.x.x release, per: https://github.com/phpstan/phpstan/blob/2.0.x/UPGRADING.md There is one upside to this upgrade, which is to be able to disable errors using their identifier (added in 1.11). Also it seems like a low-value error was removed from L5, so removed it from our configuration file.
1 parent 6de065a commit d1a742a

File tree

3 files changed

+7
-12
lines changed

3 files changed

+7
-12
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"require-dev": {
1818
"friendsofphp/php-cs-fixer": "^3.57",
1919
"phpunit/phpunit": "^9.6",
20-
"phpstan/phpstan": "^1.10"
20+
"phpstan/phpstan": "^1.12"
2121
},
2222
"replace": {
2323
"symfony/polyfill-ctype": "*",

composer.lock

Lines changed: 6 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

phpstan.neon

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ parameters:
3535
- message: '#Constant .* not found#'
3636

3737
# Low value and frequent L5 errors that are ignored by default.
38-
- message: "#^Parameter \\#1 \\$.* of function array_multisort is passed by reference, so it expects variables only\\.$#"
3938
- message: '#^Parameter \#\d+ .* of (static )?(function|method) .* expects string(\|null)?, int.* given\.$#'
4039

4140
# TODO(jchaffraix): Temporarily disabling those as they are dynamically created (see comment in Pool's constructor).

0 commit comments

Comments
 (0)