WIP: Remove Standard and Enhanced Interfaces

TODO:
* testing!
* update faq/proofreadhelp.php for the new PI

Author: cpeel

SETUP/ci/check_require_login.php

@@ -55,7 +55,6 @@
     "styles/design_philosophy.php",
     // Tools
     "tools/setlangcookie.php",  // allows unauth users to set their language
-    "tools/proofers/ctrl_frame.php",  // required for unauth quiz access
     // Dev tools
     ".php-cs-fixer.dist.php",
 ];

SETUP/db_schema.sql

@@ -542,36 +542,6 @@ CREATE TABLE `user_filters` (
   PRIMARY KEY (`username`,`filtertype`)
 );
 
---
--- Table structure for table `user_profiles`
---
-
-CREATE TABLE `user_profiles` (
-  `id` int(10) unsigned NOT NULL auto_increment,
-  `u_ref` int(10) unsigned NOT NULL default '0',
-  `profilename` varchar(30) NOT NULL default 'default',
-  `i_type` tinyint(1) default '0',
-  `i_layout` tinyint(1) default '0',
-  `v_fnts` tinyint(2) default '0',
-  `v_fntf` tinyint(1) default '2',
-  `v_fntf_other` varchar(32) default '',
-  `v_tframe` tinyint(2) default '50',
-  `v_tlines` tinyint(2) unsigned default '40',
-  `v_tchars` tinyint(2) unsigned default '65',
-  `v_tscroll` tinyint(1) default '1',
-  `v_twrap` tinyint(1) default '0',
-  `h_fnts` tinyint(2) default '0',
-  `h_fntf` tinyint(1) default '2',
-  `h_fntf_other` varchar(32) default '',
-  `h_tframe` tinyint(2) default '35',
-  `h_tlines` tinyint(2) unsigned default '6',
-  `h_tchars` tinyint(2) unsigned default '70',
-  `h_tscroll` tinyint(1) default '1',
-  `h_twrap` tinyint(1) default '0',
-  PRIMARY KEY (`id`),
-  KEY `u_ref` (`u_ref`)
-);
-
 --
 -- Table structure for table `user_project_info`
 --
@@ -648,7 +618,6 @@ CREATE TABLE `users` (
   `u_align` tinyint(1) NOT NULL default '0',
   `i_theme` varchar(100) NOT NULL default 'project_gutenberg',
   `u_id` int(10) unsigned NOT NULL auto_increment,
-  `u_profile` int(10) unsigned NOT NULL default '0',
   `u_intlang` varchar(25) default '',
   `u_privacy` tinyint(1) default '0',
   `api_key` varchar(38) DEFAULT NULL,

SETUP/devex/dpdev-docker/dp_db.sql

@@ -46,10 +46,8 @@ INSERT INTO `project_events` VALUES (1,1451401587,'projectID5682a1735f76a','pm',
 
 INSERT INTO `projects` VALUES ('Demonology','Doe, John','English','pm','Match the scan, man!','html','projectID5682a1735f76a','','proofer',1451401669,1458275991,1451401587,1599454842,'','P1.proj_avail',NULL,'testingonly',NULL,1,'Other','average',0,'','',33,32,NULL,'_internal','pm','pm','',0,'','');
 
-INSERT INTO `user_profiles` VALUES (1,1,'default',0,0,0,0,'',50,40,65,1,0,0,0,'',35,6,70,1,0),(2,2,'default',0,0,0,0,'',50,40,65,1,0,0,0,'',35,6,70,1,0),(3,3,'default',0,0,0,2,'',50,40,65,1,0,0,0,'',35,6,70,1,0);
-
 INSERT INTO `user_project_info` VALUES ('proofer','projectID5682a1735f76a',1599454853,1599454842,0,0,0,0,0,0,0,0,0);
 
-INSERT INTO `users` VALUES ('userID9f3b0f2cb891c25ffd036d11a678abce','Admin','admin','admin@localhost',1446834642,1599108129,1599108129,1,'','','',10,0,'project_gutenberg',1,1,'is_IS',0,NULL,1),('userID8dd8829eb52045889dc71ebc0920d929','Project Manager','pm','pm@localhost',1446834908,1717990305,1717990305,1,'','','',10,0,'project_gutenberg',2,2,'en_US',0,NULL,1),('userID3757fbb62df1454bff56b6f3aae608dd','Proofer','proofer','proofer@localhost',1451401482,1717996545,1717996545,1,'','','',10,0,'project_gutenberg',3,3,'en_EN',0,NULL,1);
+INSERT INTO `users` VALUES ('userID9f3b0f2cb891c25ffd036d11a678abce','Admin','admin','admin@localhost',1446834642,1599108129,1599108129,1,'','','',10,0,'project_gutenberg',1,'is_IS',0,NULL,1),('userID8dd8829eb52045889dc71ebc0920d929','Project Manager','pm','pm@localhost',1446834908,1717990305,1717990305,1,'','','',10,0,'project_gutenberg',2,'en_US',0,NULL,1),('userID3757fbb62df1454bff56b6f3aae608dd','Proofer','proofer','proofer@localhost',1451401482,1717996545,1717996545,1,'','','',10,0,'project_gutenberg',3,'en_EN',0,NULL,1);
 
 INSERT INTO `usersettings` VALUES ('admin','credit_name','real_name'),('admin','search:PM.sort','stateA'),('admin','search:PM.sort_sec','title'),('admin','sitemanager','yes'),('pm','manager','yes'),('pm','my_projects:pool_sort','titleA'),('pm','my_projects:pool_view','reserved'),('pm','my_projects:round_sort','timeD'),('pm','my_projects:round_view','recent'),('pm','pm_view','user_all'),('pm','search:PM.sort','stateA'),('pm','search:PM.sort_sec','title'),('proofer','credit_name','real_name'),('proofer','credit_other',''),('proofer','my_projects:pool_sort','titleA'),('proofer','my_projects:pool_view','reserved'),('proofer','my_projects:round_sort','timeD'),('proofer','my_projects:round_view','available'),('proofer','pm_anonymous','yes');

SETUP/tests/jsTests/dp_proofTests.js

@@ -14,18 +14,14 @@
   </script>
   <script src="../../../node_modules/qunit/qunit/qunit.js"></script>
   <script src="../../../node_modules/jquery/dist/jquery.min.js"></script>
-  <script src="../../../tools/proofers/srchrep.js"></script>
   <script src="../../../accounts/addproofer.js"></script>
-  <script src="../../../tools/proofers/dp_proof.js"></script>
   <script src="../../../scripts/misc.js"></script>
 
   <!-- tests -->
   <script src="./characterValidation.js" type="module"></script>
   <script src="./splitControlTests.js" type="module"></script>
   <script src="./formatPreviewTests.js" type="module"></script>
-  <script src="./srchrepTests.js"></script>
   <script src="./addprooferTests.js"></script>
-  <script src="./dp_proofTests.js"></script>
   <script src="./ajaxTests.js" type="module"></script>
 </body>
 </html>

SETUP/tests/jsTests/qunit.html

@@ -91,7 +91,6 @@
     {'path': 'quiz/generic/hints.php?quiz_page_id=p_basicx_2&error=arid&number=1'},
     {'path': 'quiz/generic/main.php?quiz_page_id=p_basic_1'},
     {'path': 'quiz/generic/orig.php?quiz_page_id=p_basic_2'},
-    {'path': 'quiz/generic/proof.php?quiz_page_id=p_basic_3'},
     {'path': 'quiz/generic/returnfeed.php?quiz_page_id=p_thorn'},
     {'path': 'quiz/generic/right.php?quiz_page_id=p_fraktur'},
     {'path': 'quiz/generic/wizard/default_messages.php'},
@@ -319,9 +318,6 @@
 TOOLS_PROOFERS_TESTS = [
     {'path': 'tools/proofers/for_mentors.php?round_id=P3'},
     # TODO not installed
-    {'path': 'tools/proofers/ctrl_frame.php?round_id=P3&project_id=projectID5e23a810ef693'},
-    {'path': 'tools/proofers/image_frame_std.php?projectid=projectID5e23a810ef693&proj_state=P3.proj_unavail&imagefile=001.png&page_state=P3.page_saved'},
-    {'path': 'tools/proofers/text_frame_std.php?projectid=projectID5e23a810ef693&proj_state=P3.proj_unavail&imagefile=001.png&page_state=P3.page_saved'},
     {'path': 'tools/proofers/images_index.php?project=projectID5e23a810ef693'},
     {'path': 'tools/proofers/mktable.php'},
     # TODO make non-empty
@@ -336,42 +332,17 @@
     {'path': 'tools/proofers/my_suggestions.php?round_view=familiar'},
     {'path': 'tools/proofers/my_suggestions.php?round_view=style'},
     {'path': 'tools/proofers/my_suggestions.php?round_view=different'},
-    # TODO make a valid state
-    {
-        'method': 'POST',
-        'path': 'tools/proofers/processtext.php',
-        'data': {
-            'projectid': 'projectID5e23a810ef693',
-            'proj_state': 'P3.proj_unavail',
-            'imagefile': '001.png',
-            'page_state': 'P3.page_saved',
-            'button4': '1', # B_SWITCH_LAYOUT. NB this fails because not P3.page_temp
-        },
-    },
     # TODO check redirect URL
     {
         'path': 'tools/proofers/project_topic.php?project=projectID5e23a810ef693',
         'expect_status': 302,
     },
     # TODO proof a valid state
     {'path': 'tools/proofers/proof.php?projectid=projectID5e23a810ef693&proj_state=P3.proj_unavail'},
-    # TODO proof a valid state
-    {'path': 'tools/proofers/proof_frame.php?projectid=projectID5e23a810ef693&proj_state=P3.proj_unavail'},
-    {
-        'method': 'POST',
-        'path': 'tools/proofers/report_bad_page.php',
-        'data': {
-            'projectid': 'projectID5e23a810ef693',
-            'proj_state': 'P3.proj_unavail',
-            'imagefile': '001.png',
-            'page_state': 'P3.page_saved',
-        },
-    },
     # TODO: Needs page_events or user_project_info entries to exercise properly
     {'path': 'tools/proofers/review_work.php?username=teststeel'},
     # TODO: Needs projects in P3.proj_avail to exercise properly
     {'path': 'tools/proofers/round.php?round_id=P3'},
-    {'path': 'tools/proofers/srchrep.php'},
 ]
 
 TOOLS_SITE_ADMIN_TESTS = [

SETUP/tests/jsTests/srchrepTests.js

@@ -10,13 +10,8 @@ REPLACE INTO `projects` VALUES ('An Empty Project','Fletcher, Jessica','English'
 /* `users` rows populated by INSERTs in accounts/activate.php.
  * Can't do this programatically yet.
  */
-REPLACE INTO `users` VALUES ('userID1234567890abc', 'Adam Adminston', 'admin', '[email protected]', 1234567890, 1234567890, 1234567890, 1, '', '', '', 10, 0, 'project_gutenberg', 1, 110, '', 0, 'admin_key', 1);
-REPLACE INTO `users` VALUES ('userID460b20a8a8a71','BKeir','teststeel','teststeel@localhost',1175134376,1175134406,1175134457,1,'','','',10,0,'project_gutenberg',110,119,'en_US',0,NULL,1);
-
-/* $up = new UserProfile(); $up->foo = bar; $up->save(); does not allow new
- * profiles to be created with programmatic control of id.
- */
-REPLACE INTO `user_profiles` VALUES (110,105,'default',1,1,5,6,'',50,40,65,1,0,5,6,'',35,20,70,1,0);
+REPLACE INTO `users` VALUES ('userID1234567890abc', 'Adam Adminston', 'admin', '[email protected]', 1234567890, 1234567890, 1234567890, 1, '', '', '', 10, 0, 'project_gutenberg', 1, '', 0, 'admin_key', 1);
+REPLACE INTO `users` VALUES ('userID460b20a8a8a71','BKeir','teststeel','teststeel@localhost',1175134376,1175134406,1175134457,1,'','','',10,0,'project_gutenberg',110,'en_US',0,NULL,1);
 
 /* This can be done with $s = new Settings('admin'); $s->set_true('sitemanager');
  * But there's not much point until we can do some of the rest with code.