Patch 1 (#1050)

* Patch service tag extraction

extract_ddtags_from_message checks for a service tag override using `if "service:" in` which returns true if there's a tag key that ends with `service`, eg `mail_send_service:production`.

This causes the lambda to enter the conditional to extract the tag to a first class datadog tag, but the enclosed logic includes a non-defaulted generator which checks for `startswith("service:")`. Since this second check does _not_ match the example, the generator has no elements, and the call to `next` causes the lambda to crash. 

This change swaps the check to use the same split/startswith functionality that's used inside the conditional.

* Include unit test for this edge case

* linter yelled

---------

Co-authored-by: eric-teambridge <[email protected]>

Author: ge0Aja

aws/logs_monitoring/steps/enrichment.py

@@ -161,12 +161,11 @@ def extract_ddtags_from_message(event):
         extracted_ddtags = extracted_ddtags.replace(" ", "")
 
         # Extract service tag from message.ddtags if exists
-        if "service:" in extracted_ddtags:
-            event[DD_SERVICE] = next(
-                tag[8:]
-                for tag in extracted_ddtags.split(",")
-                if tag.startswith("service:")
-            )
+        service_tags = [
+            tag for tag in extracted_ddtags.split(",") if tag.startswith("service:")
+        ]
+        if service_tags:
+            event[DD_SERVICE] = service_tags[0][8:]
             event[DD_CUSTOM_TAGS] = ",".join(
                 [
                     tag

aws/logs_monitoring/tests/test_enrichment.py

@@ -146,6 +146,31 @@ def test_extract_ddtags_handles_empty_spaces(self):
             "my_custom_service",
         )
 
+    def test_extract_ddtags_service_substring_not_prefix(self):
+        """Test that service tag extraction handles cases where 'service:' appears
+        as a substring but not as a tag prefix (e.g., in 'myservice:api').
+
+        Before the fix (old code):
+        - "service:" in extracted_ddtags would be True
+        - But next() would raise StopIteration since no tag starts with "service:"
+
+        After the fix (new code):
+        - List comprehension returns empty list when no tag starts with "service:"
+        - No exception is raised, service field is not set
+        """
+        loaded_message_tags = {"ddtags": "env:prod,myservice:api,foo:bar"}
+        event = {"message": loaded_message_tags, "ddtags": "custom_tag:value"}
+
+        extract_ddtags_from_message(event)
+
+        # Service should not be set since no tag actually starts with "service:"
+        self.assertNotIn("service", event)
+        # All tags should be preserved in the correct order
+        self.assertEqual(
+            event["ddtags"],
+            "custom_tag:value,env:prod,myservice:api,foo:bar",
+        )
+
 
 class TestExtractHostFromLogEvents(unittest.TestCase):
     def test_parse_source_cloudtrail(self):