forked from foundry-rs/foundry
-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
P-highT-bugbugSomething isn't workingSomething isn't workingdependenciesPull requests that update a dependency filePull requests that update a dependency filedocumentationImprovements or additions to documentationImprovements or additions to documentationduplicateThis issue or pull request already existsThis issue or pull request already existsenhancementNew feature or requestNew feature or requestgithub_actionsPull requests that update GitHub Actions codePull requests that update GitHub Actions codegood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededinvalidThis doesn't seem rightThis doesn't seem rightquestionFurther information is requestedFurther information is requestedrustPull requests that update rust codePull requests that update rust code
Description
Reviewer's Guide
This PR updates the workspace to version 1.4.2 and bumps dependencies, refactors and extends the formatter and parser to support Yul context, tab width configuration, and improved multiline/function header formatting, simplifies sequence conversions to borrow data, patches cheatcode account loading, adds new formatting and fork tests, updates CI config, and refines Anvil fork logic for inclusive predating.
Class diagram for updated Parser and ParseItem in doc parser
classDiagram
class Parser {
- comments: Vec<SolangComment>
- items: Vec<ParseItem>
- source: String
- tab_width: usize
+ new(comments: Vec<SolangComment>, source: String, tab_width: usize)
+ items() -> Vec<ParseItem>
}
class ParseItem {
- source: ParseSource
- code: String
+ with_code(source: &str, tab_width: usize) -> Self
}
Parser --> ParseItem
Class diagram for SensitiveScriptSequence and ScriptSequence conversion changes
classDiagram
class ScriptSequence {
- transactions: VecDeque<SensitiveTransactionMetadata>
- paths: Option<(PathBuf, PathBuf)>
- timestamp: u128
+ save(...)
}
class SensitiveScriptSequence {
- transactions: VecDeque<SensitiveTransactionMetadata>
+ from(sequence: &ScriptSequence) -> Self
}
ScriptSequence --> SensitiveScriptSequence : conversion
Class diagram for SensitiveMultiChainSequence and MultiChainSequence conversion changes
classDiagram
class MultiChainSequence {
- deployments: Vec<ScriptSequence>
- timestamp: u128
+ save(...)
}
class SensitiveMultiChainSequence {
- deployments: Vec<SensitiveScriptSequence>
+ from_multi_sequence(sequence: &MultiChainSequence) -> Self
}
MultiChainSequence --> SensitiveMultiChainSequence : conversion
Class diagram for State changes in Solidity and Yul formatting
classDiagram
class State {
+ print_lit_inner(lit: &ast::Lit, is_yul: bool)
+ print_lit(lit: &ast::Lit)
+ print_lit_yul(lit: &ast::Lit)
+ print_num_literal(source: &str, is_yul: bool)
}
class Solidity_formatting
class Yul_formatting
State <|-- Solidity_formatting
State <|-- Yul_formatting
Class diagram for Cheatcode trait implementation changes (mockCall variants)
classDiagram
class Cheatcode {
+ apply_stateful(&self, ccx: &mut CheatsCtxt) -> Result
}
class mockCall_1Call {
+ apply_stateful(&self, ccx: &mut CheatsCtxt) -> Result
}
class mockCall_3Call {
+ apply_stateful(&self, ccx: &mut CheatsCtxt) -> Result
}
class mockCalls_1Call {
+ apply_stateful(&self, ccx: &mut CheatsCtxt) -> Result
}
class make_acc_non_empty {
}
Cheatcode <|-- mockCall_1Call
Cheatcode <|-- mockCall_3Call
Cheatcode <|-- mockCalls_1Call
mockCall_1Call ..> make_acc_non_empty : uses
mockCall_3Call ..> make_acc_non_empty : uses
mockCalls_1Call ..> make_acc_non_empty : uses
File-Level Changes
| Change | Details | Files |
|---|---|---|
| Refactor literal printing to support Yul context |
|
crates/fmt/src/state/common.rscrates/fmt/src/state/sol.rscrates/fmt/src/state/yul.rscrates/fmt/src/state/mod.rs |
| Enhance multiline function header formatting |
|
crates/fmt/src/state/sol.rs |
| Introduce tab_width option in documentation parser |
|
crates/doc/src/parser/mod.rscrates/doc/src/parser/item.rscrates/doc/src/builder.rs |
| Refactor ScriptSequence to borrow instead of clone |
|
crates/script-sequence/src/sequence.rscrates/script/src/multi_sequence.rs |
| Improve cheatcode account initialization |
|
crates/cheatcodes/src/evm/mock.rs |
| Add and update formatter and fork tests |
|
crates/anvil/tests/it/fork.rscrates/fmt/tests/formatter.rscrates/fmt/testdata/IfStatement2/fmt.solcrates/fmt/testdata/ReprosFunctionDefs/all.120.fmt.solcrates/fmt/testdata/Yul/fmt.sol |
| Bump workspace version, dependencies, and CI config |
|
Cargo.toml.circleci/cargo.yml |
| Refine Anvil fork request handling |
|
crates/anvil/src/eth/api.rs |
Tips and commands
Interacting with Sourcery
- Trigger a new review: Comment
@sourcery-ai reviewon the pull request. - Continue discussions: Reply directly to Sourcery's review comments.
- Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with@sourcery-ai issueto create an issue from it. - Generate a pull request title: Write
@sourcery-aianywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai titleon the pull request to (re-)generate the title at any time. - Generate a pull request summary: Write
@sourcery-ai summaryanywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment@sourcery-ai summaryon the pull request to
(re-)generate the summary at any time. - Generate reviewer's guide: Comment
@sourcery-ai guideon the pull
request to (re-)generate the reviewer's guide at any time. - Resolve all Sourcery comments: Comment
@sourcery-ai resolveon the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore. - Dismiss all Sourcery reviews: Comment
@sourcery-ai dismisson the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai reviewto trigger a new review!
Customizing Your Experience
Access your dashboard to:
- Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others. - Change the review language.
- Add, remove or edit custom review instructions.
- Adjust other review settings.
Getting Help
- Contact our support team for questions or feedback.
- Visit our documentation for detailed guides and information.
- Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.
Originally posted by @sourcery-ai[bot] in #130 (comment)
Metadata
Metadata
Assignees
Labels
P-highT-bugbugSomething isn't workingSomething isn't workingdependenciesPull requests that update a dependency filePull requests that update a dependency filedocumentationImprovements or additions to documentationImprovements or additions to documentationduplicateThis issue or pull request already existsThis issue or pull request already existsenhancementNew feature or requestNew feature or requestgithub_actionsPull requests that update GitHub Actions codePull requests that update GitHub Actions codegood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededinvalidThis doesn't seem rightThis doesn't seem rightquestionFurther information is requestedFurther information is requestedrustPull requests that update rust codePull requests that update rust code
Projects
Status
Backlog
Status
Todo