refactor: put logic into separate methods

Author: DanielMicrosoft

src/azure-cli-core/azure/cli/core/__init__.py

@@ -210,6 +210,19 @@ def __init__(self, cli_ctx=None):
         self.cmd_to_loader_map = {}
         self.loaders = []
 
+    def _create_stub_commands_for_completion(self, command_names):
+        """Create stub commands for top-level tab completion optimization.
+        
+        Stub commands allow argcomplete to parse command names without loading modules.
+        
+        :param command_names: List of command names to create stubs for
+        """
+        from azure.cli.core.commands import AzCliCommand
+        for cmd_name in command_names:
+            if cmd_name not in self.command_table:
+                # Create stub with no-op handler - never invoked during completion
+                self.command_table[cmd_name] = AzCliCommand(self, cmd_name, lambda: None)
+
     def _update_command_definitions(self):
         for cmd_name in self.command_table:
             loaders = self.cmd_to_loader_map[cmd_name]
@@ -436,17 +449,9 @@ def _get_extension_suppressions(mod_loaders):
             index_result = command_index.get(args)
             if index_result:
                 index_modules, index_extensions = index_result
-                # Special case for top-level completion - create minimal command groups
+
                 if index_modules == TOP_LEVEL_COMPLETION_MARKER:
-                    from azure.cli.core.commands import AzCliCommand
-                    # index_extensions contains the command names, not extensions
-                    for cmd_name in index_extensions:
-                        # Create a minimal command entry for tab completion
-                        # This allows argparse to see the command without loading the module
-                        if cmd_name not in self.command_table:
-                            self.command_table[cmd_name] = AzCliCommand(
-                                self, cmd_name, lambda: None
-                            )
+                    self._create_stub_commands_for_completion(index_extensions)
                     return self.command_table
 
                 # Always load modules and extensions, because some of them (like those in
@@ -500,7 +505,6 @@ def _get_extension_suppressions(mod_loaders):
             else:
                 logger.debug("No module found from index for '%s'", args)
 
-        # No module found from the index. Load all command modules and extensions
         logger.debug("Loading all modules and extensions")
         _update_command_table_from_modules(args)
 
@@ -596,6 +600,18 @@ def __init__(self, cli_ctx=None):
             self.cloud_profile = cli_ctx.cloud.profile
         self.cli_ctx = cli_ctx
 
+    def _get_top_level_completion_commands(self):
+        """Get all command names for top-level completion optimization.
+        
+        Returns marker and command list for creating stub commands without module loading.
+        
+        :return: tuple of (TOP_LEVEL_COMPLETION_MARKER, list of command names)
+        """
+        index = self.INDEX[self._COMMAND_INDEX]
+        all_commands = list(index.keys())
+        logger.debug("Top-level completion: %d commands available", len(all_commands))
+        return TOP_LEVEL_COMPLETION_MARKER, all_commands
+
     def get(self, args):
         """Get the corresponding module and extension list of a command.
 
@@ -617,11 +633,7 @@ def get(self, args):
         if not args or args[0].startswith('-'):
             # For top-level completion (az [tab])
             if not args and self.cli_ctx.data.get('completer_active'):
-                # Return a special marker so we know to skip module loading for top-level completion
-                index = self.INDEX[self._COMMAND_INDEX]
-                all_commands = list(index.keys())
-                logger.debug("Top-level completion: %d commands available", len(all_commands))
-                return TOP_LEVEL_COMPLETION_MARKER, all_commands  # special marker, command list
+                return self._get_top_level_completion_commands()
             return None
 
         # Get the top-level command, like `network` in `network vnet create -h`