Remove data race in TestReverseProxy_ServeHTTPConcurrent/config_reloading

valyala · valyala · commit 7c9c426071f4 · 2019-03-09T00:11:29.000+02:00
diff --git a/proxy_test.go b/proxy_test.go
@@ -484,7 +484,7 @@ func TestReverseProxy_ServeHTTPConcurrent(t *testing.T) {
 	})
 	t.Run("parallel requests with config reloading", func(t *testing.T) {
 		f := func() {
-			go proxy.applyConfig(newConfig())
+			proxy.applyConfig(newConfig())
 			req := httptest.NewRequest("GET", fmt.Sprintf("%s/fast", fakeServer.URL), nil)
 			makeCustomRequest(proxy, req)
 		}

Original file line number	Diff line number	Diff line change
`@@ -484,7 +484,7 @@ func TestReverseProxy_ServeHTTPConcurrent(t *testing.T) {`
`484`	`484`	`})`
`485`	`485`	`t.Run("parallel requests with config reloading", func(t *testing.T) {`
`486`	`486`	`f := func() {`
`487`		`- go proxy.applyConfig(newConfig())`
	`487`	`+ proxy.applyConfig(newConfig())`
`488`	`488`	`req := httptest.NewRequest("GET", fmt.Sprintf("%s/fast", fakeServer.URL), nil)`
`489`	`489`	`makeCustomRequest(proxy, req)`
`490`	`490`	`}`