citest: clean up excludes

Author: sni

.golangci.yml

@@ -58,6 +58,7 @@ linters:
     lll:
       line-length: 200
   exclusions:
+    #warn-unused: true
     generated: lax
     presets:
       - comments
@@ -73,14 +74,10 @@ linters:
       - linters:
           - nolintlint
         path: (check_tcp|check_dns|nameserver.*)\.go
-      - path: (.+)\.go$
-        text: '`noCopy` is unused'
       - path: (.+)\.go$
         text: 'Magic number: 0.1, in'
       - path: (.+)\.go$
         text: 'Magic number: 0.01, in'
-      - path: (.+)\.go$
-        text: 'Magic number: 0.001, in'
       - path: (.+)\.go$
         text: 'Magic number: 2, in'
       - path: (.+)\.go$
@@ -109,8 +106,6 @@ linters:
         text: 'Magic number: 22, in'
       - path: (.+)\.go$
         text: 'Magic number: 23, in'
-      - path: (.+)\.go$
-        text: 'Magic number: 24, in'
       - path: (.+)\.go$
         text: 'Magic number: 31, in'
       - path: (.+)\.go$
@@ -121,8 +116,6 @@ linters:
         text: 'Magic number: 59, in'
       - path: (.+)\.go$
         text: 'Magic number: 60, in'
-      - path: (.+)\.go$
-        text: 'Magic number: 64, in'
       - path: (.+)\.go$
         text: 'Magic number: 100, in'
       - path: (.+)\.go$
@@ -133,8 +126,6 @@ linters:
         text: 'Magic number: 365, in'
       - path: (.+)\.go$
         text: 'Magic number: 500, in'
-      - path: (.+)\.go$
-        text: 'Magic number: 512, in'
       - path: (.+)\.go$
         text: 'Magic number: 600, in'
       - path: (.+)\.go$
@@ -151,40 +142,16 @@ linters:
         text: 'Magic number: 1e6, in'
       - path: (.+)\.go$
         text: 'Magic number: 1e7, in'
-      - path: (.+)\.go$
-        text: 'Magic number: 1e9, in'
-      - path: (.+)\.go$
-        text: 'Magic number: 1e12, in'
-      - path: (.+)\.go$
-        text: 'Magic number: 1e15, in'
       - path: (.+)\.go$
         text: 'Magic number: 0o600, in'
       - path: (.+)\.go$
         text: 'Magic number: 0o700, in'
-      - path: (.+)\.go$
-        text: noCopy is missing in
       - path: (.+)\.go$
         text: variable name 'ok' is too short
       - path: (.+)\.go$
         text: Function 'setListenTLSConfig' has too many statements
-      - path: (.+)\.go$
-        text: Function 'parseAnyArg' has too many statements
-      - path: (.+)\.go$
-        text: complexity.*setListenTLSConfig
-      - path: (.+)\.go$
-        text: complexity.*checkFlags
-      - path: (.+)\.go$
-        text: Function 'readConfiguration' has too many statements
-      - path: (.+)\.go$
-        text: complexity.*readConfiguration
-      - path: (.+)\.go$
-        text: Function 'Check' has too many statements
       - path: (.+)\.go$
         text: Function 'Check' is too long
-      - path: (.+)\.go$
-        text: Function 'fetchProcs' is too long
-      - path: (.+)\.go$
-        text: Function 'buildListMacros' is too long
       - path: (.+)\.go$
         text: Function 'fetchProcs' has too many statements
       - path: (.+)\.go$
@@ -195,8 +162,6 @@ linters:
         text: cognitive complexity .* of func .*conditionAdd
       - path: (.+)\.go$
         text: cognitive complexity .* of func .*.matchSingle
-      - path: (.+)\.go$
-        text: cognitive complexity .* of func .*splitToken
       - path: (.+)\.go$
         text: cognitive complexity .* of func .*ReplaceConditionals
       - path: (.+)\.go$
@@ -223,8 +188,6 @@ linters:
         text: parameter name 'a' is too short for the scope of its usage
       - path: (.+)\.go$
         text: parameter name 'b' is too short for the scope of its usage
-      - path: (.+)\.go$
-        text: .execCommand` - `timeout` always receives `DefaultCmdTimeout
       - path: (.+)\.go$
         text: 'fieldalignment: struct'
       - path: (.+)(utils|utils_test|fieldsn|asciiTable)\.go$
@@ -245,9 +208,6 @@ linters:
         text: 'SA4023'
     paths:
       - pkg/pdh/pdh.go
-      - third_party$
-      - builtin$
-      - examples$
 issues:
   max-issues-per-linter: 0
   max-same-issues: 0
@@ -257,8 +217,3 @@ formatters:
     - goimports
   exclusions:
     generated: lax
-    paths:
-      - pkg/pdh/pdh.go
-      - third_party$
-      - builtin$
-      - examples$

pkg/pdh/pdh.go

@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build windows
-// +build windows
 
 package pdh
 

pkg/snclient/check_drivesize_windows.go

@@ -251,14 +251,14 @@ func (l *CheckDrivesize) setDeviceInfo(drive map[string]string) {
 		drive["removable"] = "1"
 	}
 
-	volumeName := make([]uint16, 512)
+	volumeName := make([]uint16, windows.MAX_PATH+1)
 	volumeNameLen, err := convert.UInt32E(len(volumeName))
 	if err != nil {
 		drive["_error"] = fmt.Sprintf("cannot set length of volume name: %s", err.Error())
 
 		return
 	}
-	fileSystemName := make([]uint16, 512)
+	fileSystemName := make([]uint16, windows.MAX_PATH+1)
 	fileSystemNameLen, err := convert.UInt32E(len(fileSystemName))
 	if err != nil {
 		drive["_error"] = fmt.Sprintf("cannot set length of filesystem name: %s", err.Error())