Commit 678235e
fix: update typer to >=0.12.4 for PEP 604 union type support
PR #349 changed type hints from Optional[bool] to bool | None syntax,
but typer < 0.12.4 doesn't support PEP 604 union types (X | None).
This caused RuntimeError when running comfy CLI with older typer.
Changes:
- Update typer dependency from >=0.9 to >=0.12.4
- Remove deprecated is_flag parameter from typer.Option() calls
(is_flag was deprecated in typer 0.15.0 and never worked properly)
Fixes #355
References:
- Typer PEP 604 support: fastapi/typer#548
- is_flag deprecation: fastapi/typer#986
Amp-Thread-ID: https://ampcode.com/threads/T-019bdd23-62ea-732f-9443-5705ebe27a3b
Co-authored-by: Amp <[email protected]>1 parent 88dba42 commit 678235e
File tree
3 files changed
+1
-9
lines changed- comfy_cli
- command/custom_nodes
3 files changed
+1
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
80 | 79 | | |
81 | 80 | | |
82 | 81 | | |
| |||
85 | 84 | | |
86 | 85 | | |
87 | 86 | | |
88 | | - | |
89 | 87 | | |
90 | 88 | | |
91 | 89 | | |
| |||
94 | 92 | | |
95 | 93 | | |
96 | 94 | | |
97 | | - | |
98 | 95 | | |
99 | 96 | | |
100 | 97 | | |
| |||
103 | 100 | | |
104 | 101 | | |
105 | 102 | | |
106 | | - | |
107 | 103 | | |
108 | 104 | | |
109 | 105 | | |
| |||
112 | 108 | | |
113 | 109 | | |
114 | 110 | | |
115 | | - | |
116 | 111 | | |
117 | 112 | | |
118 | 113 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
200 | 200 | | |
201 | 201 | | |
202 | 202 | | |
203 | | - | |
204 | 203 | | |
205 | 204 | | |
206 | 205 | | |
207 | 206 | | |
208 | 207 | | |
209 | | - | |
210 | 208 | | |
211 | 209 | | |
212 | 210 | | |
213 | 211 | | |
214 | 212 | | |
215 | | - | |
216 | 213 | | |
217 | 214 | | |
218 | 215 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| |||
0 commit comments