192 add warning log when av related helm values are detected (#194)

* feat(helm): add warning log when deprecated AV settings are detected

Fixes: #192

- Added a startup warning when any Audio/Video related values
  (av.enabled, av.serverIP, av.stunServers, av.jitsiUrl) are present
  in Helm chart configurations.
- Ensures deployments are notified that built in A/V support is no
  longer available.
- No functional behavior changed, only logs a warning at container start.

* chore: add AV deprecation warning and clean up env vars

- Add Helm NOTES warning when AV related values are configured
- Remove unused CT_AV_DEPRECATED_WARNING environment variable from Deployment
- Keep AV env configuration minimal while clearly signaling that A/V is no longer supported

Author: danc094codetogether

charts/collab/templates/NOTES.txt

@@ -3,3 +3,21 @@ Application URL:
   {{- $host := (urlParse .Values.codetogether.url).host }}
   http{{ if $.Values.ingress.tls }}s{{ end }}://{{ $host }}{{ .path }}
 {{- end }}
+
+{{- if or .Values.av.enabled .Values.av.serverIP .Values.av.stunServers.enabled .Values.av.jitsiUrl }}
+
+###############################################################################
+# WARNING: A/V OPTIONS DEPRECATED
+###############################################################################
+Audio/Video options were detected in your Helm values:
+
+  av.enabled              = {{ .Values.av.enabled | default "false" }}
+  av.serverIP             = {{ .Values.av.serverIP | default "" }}
+  av.stunServers.enabled  = {{ .Values.av.stunServers.enabled | default "false" }}
+  av.jitsiUrl             = {{ .Values.av.jitsiUrl | default "" }}
+
+A/V is no longer supported and these settings will be ignored by the server.
+Please remove these values from your codetogether-values.yaml.
+###############################################################################
+
+{{- end }}

charts/collab/templates/deployment.yaml

@@ -111,14 +111,6 @@ spec:
           - name: CT_AV_ENABLED
             value: {{ .Values.av.enabled | quote }}
 
-          # ------------------------------
-          # A/V DEPRECATION NOTICE
-          # ------------------------------
-          {{- if or .Values.av.enabled .Values.av.serverIP .Values.av.stunServers.enabled .Values.av.jitsiUrl }}
-          - name: CT_AV_DEPRECATED_WARNING
-            value: "Audio/Video options detected in Helm values, but A/V is no longer supported and will be ignored."
-          {{- end }}
-
           {{- if .Values.av.enabled }} 
           - name: CT_AV_LAN_IP
             value: {{ .Values.av.serverIP | quote }}