Add Helper method to ASMDataTable (#267)

* add helper and doc

* add helper and doc

* fix string

* err usage

* fix

Author: Ecdcaeb

src/main/java/net/minecraftforge/common/ForgeModContainer.java

@@ -530,9 +530,9 @@ public void modConstruction(FMLConstructionEvent evt)
         }
 
         List<String> all = Lists.newArrayList();
-        for (ASMData asm : evt.getASMHarvestedData().getAll(ICrashReportDetail.class.getName().replace('.', '/')))
+        for (ASMData asm : evt.getASMHarvestedData().getAll(ICrashReportDetail.class))
             all.add(asm.getClassName());
-        for (ASMData asm : evt.getASMHarvestedData().getAll(ICrashCallable.class.getName().replace('.', '/')))
+        for (ASMData asm : evt.getASMHarvestedData().getAll(ICrashCallable.class))
             all.add(asm.getClassName());
         // Add table classes for mod list tabulation
         all.add("net/minecraftforge/common/util/TextTable");

src/main/java/net/minecraftforge/common/MinecraftForge.java

@@ -104,9 +104,9 @@ public static void preloadCrashClasses(ASMDataTable table, String modID, Set<Str
    {
        //Find all ICrashReportDetail's handlers and preload them.
        List<String> all = Lists.newArrayList();
-       for (ASMData asm : table.getAll(ICrashReportDetail.class.getName().replace('.', '/')))
+       for (ASMData asm : table.getAll(ICrashReportDetail.class))
            all.add(asm.getClassName());
-       for (ASMData asm : table.getAll(ICrashCallable.class.getName().replace('.', '/')))
+       for (ASMData asm : table.getAll(ICrashCallable.class))
            all.add(asm.getClassName());
 
        all.retainAll(classes);

src/main/java/net/minecraftforge/common/capabilities/CapabilityManager.java

@@ -102,7 +102,7 @@ public <T> void register(Class<T> type, Capability.IStorage<T> storage, Callable
     private IdentityHashMap<String, List<Function<Capability<?>, Object>>> callbacks = Maps.newIdentityHashMap();
     public void injectCapabilities(ASMDataTable data)
     {
-        for (ASMDataTable.ASMData entry : data.getAll(CapabilityInject.class.getName()))
+        for (ASMDataTable.ASMData entry : data.getAll(CapabilityInject.class))
         {
             final String targetClass = entry.getClassName();
             final String targetName = entry.getObjectName();

src/main/java/net/minecraftforge/common/config/ConfigManager.java

@@ -106,7 +106,7 @@ private static void register(Class<?> cls, ITypeAdapter adpt)
     public static void loadData(ASMDataTable data)
     {
         FMLLog.log.debug("Loading @Config anotation data");
-        for (ASMData target : data.getAll(Config.class.getName()))
+        for (ASMData target : data.getAll(Config.class))
         {
             String modid = (String)target.getAnnotationInfo().get("modid");
             Multimap<Config.Type, ASMData> map = asm_data.computeIfAbsent(modid, k -> ArrayListMultimap.create());

src/main/java/net/minecraftforge/fml/common/LoadController.java

@@ -170,9 +170,10 @@ public void distributeStateMessage(LoaderState state, Object... eventData)
 
                     FMLContextQuery.init(); // Initialize FMLContextQuery and add it to the global list
 
+
                     // Load late mixins
                     FMLLog.log.info("Instantiating all ILateMixinLoader implemented classes...");
-                    for (ASMDataTable.ASMData asmData : asmDataTable.getAll(ILateMixinLoader.class.getName().replace('.', '/'))) {
+                    for (ASMDataTable.ASMData asmData : asmDataTable.getAll(ILateMixinLoader.class)) {
                         try {
                             modClassLoader.addFile(asmData.getCandidate().getModContainer()); // Add to path before `newInstance`
                             Class<?> clazz = Class.forName(asmData.getClassName().replace('/', '.'));

src/main/java/net/minecraftforge/fml/common/discovery/ASMDataTable.java

@@ -55,22 +55,30 @@ public ASMData(ModCandidate candidate, String annotationName, String className,
             this.objectName = objectName;
             this.annotationInfo = info;
         }
+
         public ModCandidate getCandidate()
         {
             return candidate;
         }
+
         public String getAnnotationName()
         {
             return annotationName;
         }
+
+        /**
+         * @return the internal name
+         */
         public String getClassName()
         {
             return className;
         }
+
         public String getObjectName()
         {
             return objectName;
         }
+        
         public Map<String, Object> getAnnotationInfo()
         {
             return annotationInfo;
@@ -108,9 +116,9 @@ public boolean apply(ASMData data)
     private Map<ModContainer, SetMultimap<String,ASMData>> containerAnnotationData;
 
     private List<ModContainer> containers = Lists.newArrayList();
-    private SetMultimap<String,ModCandidate> packageMap = HashMultimap.create();
+    private SetMultimap<String, ModCandidate> packageMap = HashMultimap.create();
 
-    public SetMultimap<String,ASMData> getAnnotationsFor(ModContainer container)
+    public SetMultimap<String, ASMData> getAnnotationsFor(ModContainer container)
     {
         if (containerAnnotationData == null)
         {
@@ -122,9 +130,27 @@ public SetMultimap<String,ASMData> getAnnotationsFor(ModContainer container)
         return containerAnnotationData.get(container);
     }
 
-    public Set<ASMData> getAll(String annotation)
+    /**
+     * @param type The canonical name of a annotation type
+     *              Or the internal name of a interface type
+     * @return the asm datas
+     */
+    public Set<ASMData> getAll(String type)
+    {
+        return globalAnnotationData.get(type);
+    }
+
+    /**
+     * @param type interface of annotation
+     * @return the asm datas
+     */
+    public Set<ASMData> getAll(Class<?> type)
     {
-        return globalAnnotationData.get(annotation);
+        if (type.isInterface()) {
+            return this.getAll(type.getName().replace('.', '/'));
+        } else if (type.isAnnotation()) {
+            return this.getAll(type.getName());
+        } else throw new IllegalArgumentException("The type are trying to be got from ASMDataTable is neither annotation nor interface");
     }
 
     public void addASMData(ModCandidate candidate, String annotation, String className, @Nullable String objectName, @Nullable Map<String,Object> annotationInfo)

src/main/java/net/minecraftforge/fml/common/registry/ItemStackHolderInjector.java

@@ -47,7 +47,7 @@ public void inject() {
 
     public void findHolders(ASMDataTable table) {
         FMLLog.log.info("Identifying ItemStackHolder annotations");
-        Set<ASMData> allItemStackHolders = table.getAll(GameRegistry.ItemStackHolder.class.getName());
+        Set<ASMData> allItemStackHolders = table.getAll(GameRegistry.ItemStackHolder.class);
         Map<String, Class<?>> classCache = Maps.newHashMap();
         for (ASMData data : allItemStackHolders)
         {

src/main/java/net/minecraftforge/registries/ObjectHolderRegistry.java

@@ -49,10 +49,10 @@ public enum ObjectHolderRegistry
     public void findObjectHolders(ASMDataTable table)
     {
         FMLLog.log.info("Processing ObjectHolder annotations");
-        Set<ASMData> allObjectHolders = table.getAll(GameRegistry.ObjectHolder.class.getName());
+        Set<ASMData> allObjectHolders = table.getAll(GameRegistry.ObjectHolder.class);
         Map<String, String> classModIds = Maps.newHashMap();
         Map<String, Class<?>> classCache = Maps.newHashMap();
-        for (ASMData data : table.getAll(Mod.class.getName()))
+        for (ASMData data : table.getAll(Mod.class))
         {
             String modid = (String)data.getAnnotationInfo().get("modid");
             classModIds.put(data.getClassName(), modid);