TODO in OpenCiviWiki/project/accounts/models.py

[gabeschreiber]

Hello, I was looking through code files for this project and noticed a TODO comment from a few years ago for the resize_profile_image method in the User class, I would like to work on this if this issue still needs addressing. Please let me know. Thank you!

[brylie]

Thanks! What does the TODO comment describe? That might give us some idea of what the task will entail.

[gabeschreiber]

Thanks! What does the TODO comment describe? That might give us some idea of what the task will entail.

TODO: try to remove this resize_profile_image method

or find a more simple way to acheive the goal(s)

- less disk space?

- desired shape?

Basically it was to simplify or eliminate the method by combining it into another.

[brylie]

Good to know. What do you think about how the function can be simplified or any alternative approaches?

We can ignore the disk space and desired shape questions. That way, we can focus on whether there is a more simple way to implement image resizing.

[gabeschreiber]

I was thinking you might be able to use django-imagekit to do the same resizing/processing for the thumbnails for you, but I'm a little unsure on how to integrate an app like that into a project of this scale so I might need some guidance on that. Another thing I though was there might be a way to integrate the process into the save function in the same file. Save calls resize_profile_image and I was thinking you combine them and eliminate the need for resize_profile_image.

[gabeschreiber]

I've never used ImageKit but the documentation looks pretty good online and it seems like a good application for it. Let me know what you think! Thank you :)

[brylie]

Sounds good 👍