Merge pull request #198 from CiscoTestAutomation/release_25.10

Release 25.10

Author: Taarini

Makefile

@@ -48,7 +48,7 @@ RELATED_PKGS += genie.libs.filetransferutils
 # Adding pyasyncore pkg to fix pysnmp scripts for python 3.12
 DEPENDENCIES = restview psutil Sphinx wheel asynctest 'pysnmp>=6.1.4,<6.2' pyasn1==0.6.0
 DEPENDENCIES += sphinx-rtd-theme==1.1.0 pyftpdlib tftpy\<0.8.1 robotframework
-DEPENDENCIES += Cython requests ruamel.yaml grpcio protobuf jinja2
+DEPENDENCIES += Cython requests ruamel.yaml grpcio protobuf jinja2 pyVmomi
 # Internal variables.
 # (note - build examples & templates last because it will fail uploading to pypi
 #  due to duplicates, and we'll for now accept that error)

pkgs/clean-pkg/changelog/2025/october.rst

@@ -0,0 +1,32 @@
+--------------------------------------------------------------------------------
+                                      Fix                                       
+--------------------------------------------------------------------------------
+
+* iosxe
+    * Modified configure_enable_aes_encryption API
+        * Added support to handle Old Masteer key prompt.
+
+* clean-pkg/stages
+    * iosxe
+        * Updated ping_gateway in ConfigureManagement stage to attempt ping multiple times
+    * iosxe
+        * Increased the default reload_wait from 30 seconds to 150 seconds to allow sufficient time to match the reload patterns.
+    * iosxe
+        * Updated install image logic to skip the "Check for previous uncommitted install operation" step when the show install active output has no packages to commit.
+
+
+--------------------------------------------------------------------------------
+                                      New                                       
+--------------------------------------------------------------------------------
+
+* clean
+    * IOSXE
+        * Update clean install images to retry install image if there is not enough space after cleaning unprotected files.
+    * IOSXE/cat9k
+        * Delete clean install images logic for car9k stack devices to use the logic from IOSXE.
+
+* iosxe
+    * clean-pkg
+        * Updated install image stage to collect debug logs on failure
+
+

pkgs/clean-pkg/sdk_generator/output/github_clean.json

@@ -8,7 +8,7 @@
 '''
 
 # metadata
-__version__ = "25.9"
+__version__ = "25.10"
 __author__ = 'Cisco Systems Inc.'
 __contact__ = ['[email protected]', '[email protected]']
 __copyright__ = 'Copyright (c) 2019, Cisco Systems Inc.'

pkgs/clean-pkg/src/genie/libs/clean/__init__.py

@@ -6,4 +6,4 @@ class StackMemberConfigException(CleanException):
     """
     Exception for when all the member of stack device is configured
     """
-    pass
+    pass

pkgs/clean-pkg/src/genie/libs/clean/exception.py

@@ -129,8 +129,16 @@ execute1:
 
 
       Configuration register is 0x2102
+    config term:
+        new_state: configure
   prompt: "%N#"
 
+configure:
+  prompt: "%N(config)#"
+  commands:
+    end:
+        new_state: execute1
+
 do_you_want_to_remove1:
   preface:
     timing:

pkgs/clean-pkg/src/genie/libs/clean/stages/iosxe/asr1k/tests/test_verify_running_image/mock_data/iosxe/mock_data.yaml

@@ -5,7 +5,6 @@
 import time
 from datetime import datetime, timedelta
 
-
 from pyats.async_ import pcall
 
 from genie.abstract import Lookup
@@ -36,7 +35,6 @@
 # Logger
 log = logging.getLogger(__name__)
 
-
 class ChangeBootVariable(IOSXEChangeBootVariable):
     """This stage configures boot variables of the device using the following steps:
 
@@ -910,119 +908,3 @@ def check_start_up_config_variables(self, steps, device):
             except Exception as e:
                 step.failed("Failed to check for debug config in rommon variables",
                             from_exception=e)
-
-    def install_image(self, steps, device, images,
-                      install_timeout=INSTALL_TIMEOUT,
-                      save_system_config=SAVE_SYSTEM_CONFIG,
-                      reload_args=RELOAD_SERVICE_ARGS,
-                      issu=ISSU, stack_member_timeout=STACK_MEMBER_TIMEOUT,
-                      stack_member_interval=STACK_MEMBER_INTERVAL,
-                      skip_save_running_config=SKIP_SAVE_RUNNING_CONFIG,
-                      reload_wait=RELOAD_WAIT):
-        # check if device is a stack device otherwise call the InstallImage for 
-        # iosxe devices.
-        if hasattr(device, 'chassis_type') and device.chassis_type == 'stack':
-            with steps.start(f"Installing image '{images[0]}'") as step:
-                # create a new instance for stackutils which include some utility 
-                # apis for working with stack devices
-                stack_utils = StackUtils()
-                # get tredundancy info of the stack device 
-                stack_redundency_info = stack_utils.get_redundancy_details(device)
-                number_of_stack_members = len(stack_redundency_info)
-                # make sure device is do not manual boot
-                device.api.configure_no_boot_manual()
-                # write to memory 
-                device.api.execute_write_memory()
-
-                def _update_counter_for_member_config(spawn, context, session):
-                    """ Handles the number of apply configure message seen after install image """
-                    if not session.get("member_config"):
-                        session['member_config'] = 1
-                        spawn.log.debug(f"member config {session['member_config']}")
-                    else:
-                        session['member_config'] += 1
-                        spawn.log.debug(f"member config {session['member_config']}")
-                    if session['member_config'] == number_of_stack_members - 1:
-                        # this is raised when all the member are done for configuration
-                        raise StackMemberConfigException
-                    
-                def _failed_to_install_image(spawn):
-                    raise Exception
-                
-                def _check_for_member_config(spawn, session):
-                    # check the session for member_config, if this is not the spawn of 
-                    # active connection we will not see the member config in buffer so
-                    # we should get out of the dialog loop after seeing press return.
-                    if not session.get('member_config'):
-                        raise StackMemberConfigException
-
-                dialog = Dialog([
-                    Statement(pattern=r"Do you want to proceed\? \[y\/n\]",
-                            action='sendline(y)',
-                            loop_continue=True,
-                            continue_timer=False),
-                    Statement(pattern=r".*Applying config on Switch \d+.*\[DONE\]$",
-                            action= _update_counter_for_member_config,
-                            loop_continue=True,
-                            continue_timer=False),
-                    Statement(pattern=r".*FAILED:.*?",
-                            action=_failed_to_install_image,
-                            loop_continue=False,
-                            continue_timer=False),
-                    Statement(pattern=r'Press RETURN to get started.*',
-                              action=_check_for_member_config,
-                              loop_continue=True,
-                              continue_timer=False)
-                ])
-                
-                install_cmd = 'install add file {} activate commit'
-                if issu:
-                    install_cmd = 'install add file {} activate issu commit'
-                    
-                device.sendline(install_cmd.format(images[0]))
-                
-                try:
-                    dialog.process(device.spawn,
-                                   timeout = install_timeout,
-                                   context=device.context)
-                except StackMemberConfigException:
-                    log.debug("Expected exception continue with the stage")
-                    log.info('Waiting for buffer to settle down')
-                    post_reload_wait_time = reload_args.get('post_reload_wait', 15)
-                    post_reload_timeout = reload_args.get('post_reload_timeout', 60)
-                    start_time = current_time = datetime.now()
-                    timeout_time = timedelta(seconds=post_reload_timeout)
-                    settle_time = current_time = datetime.now()
-                    while (current_time - settle_time) < timeout_time:
-                        if buffer_settled(device.spawn, post_reload_wait_time):
-                            log.info('Buffer settled, accessing device..')
-                            break
-                        current_time = datetime.now()
-                        if (current_time - start_time) > timeout_time:
-                            log.info('Time out, trying to access device..')
-                            break
-                    device.enable()
-                except Exception as e:
-                    step.failed("Failed to install the image", from_exception=e)
-
-                # Check all the members are ready and then try to disconnect and connect to device.
-                if stack_utils.is_all_member_ready(device, stack_member_timeout, stack_member_interval):
-                    log.info('Disconnecting and reconnecting')
-                    device.disconnect()
-                    device.connect()
-                else:
-                    step.failed("Stack members are not ready")
-
-                image_mapping = self.history['InstallImage'].parameters.setdefault(
-                    'image_mapping', {})
-                if hasattr(self, 'new_boot_var'):
-                    image_mapping.update({images[0]: self.new_boot_var})
-        else:
-            # if device is not a stack device we all the install image for iosxe 
-            super().install_image(steps, device, images,
-                      save_system_config=save_system_config,
-                      install_timeout=install_timeout,
-                      reload_service_args=None,
-                      issu=issu,
-                      reload_wait=reload_wait
-                      )