Fix sonar column start position (AST-65811) (#1051)

* Fix sonar column start position (AST-65811)

* Fix sonar column start position (AST-65811)

* Fix sonar column start position (AST-65811)

* Fix sonar column start position (AST-65811)

* Update ci.yml

---------

Co-authored-by: AlvoBen <144705560+AlvoBen@users.noreply.github.com>

Author: cx-daniel-greenspan

.github/workflows/ci.yml

@@ -172,7 +172,6 @@ jobs:
           vuln-type: 'os,library'
           output: './trivy-image-results.txt'
         env:
-          TRIVY_SKIP_DB_UPDATE: true
           TRIVY_SKIP_JAVA_DB_UPDATE: true
 
       - name: Inspect action report

internal/commands/result.go

@@ -2217,11 +2217,15 @@ func parseSonarSecondaryLocations(results *wrappers.ScanResult) []wrappers.Sonar
 func parseSonarTextRange(results *wrappers.ScanResultNode) wrappers.SonarTextRange {
 	var auxTextRange wrappers.SonarTextRange
 	auxTextRange.StartLine = results.Line
-	auxTextRange.StartColumn = results.Column
-	auxTextRange.EndColumn = results.Column + results.Length
+	startColumn := getSastStartColumn(results.Column)
+
+	auxTextRange.StartColumn = startColumn
+	auxTextRange.EndColumn = startColumn + results.Length
+
 	if auxTextRange.StartColumn == auxTextRange.EndColumn {
 		auxTextRange.EndColumn++
 	}
+
 	return auxTextRange
 }
 
@@ -2241,6 +2245,13 @@ func findRule(ruleIds map[interface{}]bool, result *wrappers.ScanResult) *wrappe
 	return nil
 }
 
+func getSastStartColumn(column uint) uint {
+	if column == 0 {
+		return 0
+	}
+	return column - 1
+}
+
 func findRuleID(result *wrappers.ScanResult) (ruleID, ruleName, shortMessage string) {
 	caser := cases.Title(language.English)