Questions about loading osmChanges, and modifying stops

[nereocystis]

I like what I see with gtfs-osm-sync.

It's much better than the manually editing and adding 4800 stops.

But I do have a few questions.

I want to accept a few nodes, then create a file to be uploaded, put it into josm, verify that everything is correct, then upload the file.

With nearly 1000 stops which may match GTFS, I don't have the patience to handle everything at once.

I'm part way there, but I wonder what the standard procedure is.

I'm using AC Transit's GTFS files, from
http://www.actransit.org/wp-content/uploads/GTFSSummer18.zip

I have a verbal OK from AC Transit. They don't have time to do it themselves.

I have made some modifications to my copy of gtfs-osm-sync, but I have also tried it on an unchanged copy.

My current use case is to find stops which may already be in OSM, select the correct rows, save the changes, and then upload the changes.

For now, I am skipping routes, and only handling stops. I will examine the routes later, and I have some suggestions for modifying the way routes are handled.

In my data, there are 900 possible matched OSM stops, and I don't feel like examining all of them at once.

If I check "Existing stops with updates", I go through the stops one at a time. I can successfully select values from my preferred column. I choose "Accept & Save Change", and go to the next stop.

Bad news is that only 20 stops are in this category, good news is that it works, with my code modifications.

I tried using "Dummy Upload", along with "Don't Up Remain", and usually ended up with one stop, and not a stop which I want to change.

So I modified that the code, adding a button "Accepted Upload", which only uploads stops which I have accepted.

It seems to work for "Existing stops with updates", but for "New GTFS stops with Potential Matches in OSM", I get both a new node from GTFS, and a modified node OSM. My preference is to just have a modified node with combined values.

I think that I see the code which handles some of this, in generateStopsToUpload(), but I'm just starting to look at it.

[nereocystis]

OK. I have solution, and a better description of the problem.

The short description is that:
"New GTFS stops with Potential Matches in OSM"
does not update finalStops in tableStopButtonActionPerformed()
I'll put together a few patches for consideration.

[barbeau]

Thanks for looking at this @nereocystis!

[nereocystis]

I have made progress, with some patches I have shared, and some I have not yet shared.

And now, I have managed to get 300 out of 1000 AC Transit bus stops in OSM matched with GTFS files.

I have added a patch which let's me create an upload file consisting only of nodes where I have accepted the changes. This allows me to view 20-100 nodes at a stretch, save the changes to a files, then upload the changes using josm.

Then I can revisit the data when I have time again.

Currently, I have the following changes:

Gtfs potential matches #41 #41

Gtfs data null #43 #43

Sort osm stops by distance from gtfs stop #45 #45

A fix related to setting osmVersion, to avoid setting null osmVersion

Prefer newer GTFS values to OSM values for MODIFY

Temporarily avoid adding FIXME, and notes about adding gtfs_id, because merging is quicker.

Temporarily avoid showing potential matches when gtfs_id does not match. Eventually, I may review the nodes related to this change.

Reduce the distance for potential matches. For my data set, this seems OK. Probably this should be settable by the user.

I see a few bugs here and there, which I have not yet resolved. Might be my bugs, might be already existing.

[reubot]

In my last push here, I added the option to only export accepted stops, this should be what you are after.