Apply suggestions from code review

AI is so great

Co-authored-by: Copilot <[email protected]>

Author: 502y

src/main/java/i18nupdatemod/I18nUpdateMod.java

@@ -105,7 +105,7 @@ public static void init(Path minecraftPath, String minecraftVersion, String load
 
             //Apply resource pack
             LoadDetailUI.setStage(LoadStage.APPLY_RESOURCE_PACK);
-            if (shouldShutdown){
+            if (shouldShutdown) {
                 return;
             }
             GameConfig config = new GameConfig(minecraftPath.resolve("options.txt"));

src/main/java/i18nupdatemod/core/I18nConfig.java

@@ -62,7 +62,7 @@ public static GameAssetDetail getAssetDetail(String minecraftVersion, String loa
         LoadDetailUI.appendLog("正在获取最快的镜像源...");
         String assetRoot = getFastestUrl();
         Log.debug("Using asset root: " + assetRoot);
-        LoadDetailUI.appendLog("即将从"+assetRoot+"下载资源包");
+        LoadDetailUI.appendLog("即将从 " + assetRoot + " 下载资源包");
 
         if (assetRoot.equals("https://raw.githubusercontent.com/")) {
             ret.downloads = createDownloadDetailsFromGit(convert, loader);

src/main/java/i18nupdatemod/core/LoadDetailUI.java

@@ -56,10 +56,10 @@ public void windowClosing(WindowEvent e) {
 
         // 状态栏
         statusBar = new JProgressBar();
-        statusBar.setString("正在合并资源包");
+        statusBar.setString(LoadStage.getDescription(LoadStage.INIT));
         statusBar.setStringPainted(true);
         statusBar.setMaximum(LoadStage.values().length - 1);
-        statusBar.setValue(100);
+        statusBar.setValue(0);
         statusBar.setForeground(new Color(102, 255, 102));
         panel.add(statusBar);
         panel.add(Box.createVerticalStrut(10));
@@ -106,15 +106,15 @@ public static void show() {
         if (!gui.useGUI || gui.frame == null) {
             return;
         }
-        gui.frame.setVisible(true);
+        SwingUtilities.invokeLater(() -> gui.frame.setVisible(true));
     }
 
     public static void hide() {
         LoadDetailUI gui = getInstance();
         if (!gui.useGUI || gui.frame == null) {
             return;
         }
-        gui.frame.setVisible(false);
+        SwingUtilities.invokeLater(() -> gui.frame.setVisible(false));
     }
 
     private void shutdown(){

src/main/java/i18nupdatemod/core/ResourcePack.java

@@ -41,14 +41,14 @@ public ResourcePack(String filename, boolean saveToGame) {
 
     public void checkUpdate(String fileUrl, String md5Url) throws IOException, URISyntaxException, NoSuchAlgorithmException {
         if (isUpToDate(md5Url)) {
-            LoadDetailUI.appendLog(filename + "无需更新");
+            LoadDetailUI.appendLog(filename + " 无需更新");
             Log.debug("Already up to date.");
             return;
         }
         //In this time, we can only download full file
-        LoadDetailUI.appendLog("正在下载" + filename);
+        LoadDetailUI.appendLog("正在下载 " + filename);
         downloadFull(fileUrl, md5Url);
-        LoadDetailUI.appendLog(filename + "下载完成");
+        LoadDetailUI.appendLog(filename + " 下载完成");
         //In the future, we will download patch file and merge local file
     }
 

src/main/java/i18nupdatemod/core/ResourcePackConverter.java

@@ -40,7 +40,7 @@ public void convert(int packFormat, String description) throws Exception {
 //            zos.setMethod(ZipOutputStream.STORED);
             for (Path p : sourcePath) {
                 Log.info("Converting: " + p);
-                LoadDetailUI.appendLog("正在转换" + p);
+                LoadDetailUI.appendLog("正在转换 " + p);
                 try (ZipFile zf = new ZipFile(p.toFile(), StandardCharsets.UTF_8)) {
                     for (Enumeration<? extends ZipEntry> e = zf.entries(); e.hasMoreElements(); ) {
                         ZipEntry ze = e.nextElement();

src/main/java/i18nupdatemod/entity/LoadStage.java

@@ -1,6 +1,6 @@
 package i18nupdatemod.entity;
 
-public enum LoadStage{
+public enum LoadStage {
     INIT(0),
     DOWNLOAD_ASSET(1),
     CONVERT_RESOURCE_PACK(2),
@@ -18,7 +18,7 @@ public int getValue() {
     }
 
     public static String getDescription(LoadStage stage) {
-        switch (stage){
+        switch (stage) {
             case INIT:
                 return "初始化";
             case DOWNLOAD_ASSET: