Skip to content

Commit 68a39fc

Browse files
authored
Merge pull request #2 from Breeding-Insight/bug/BI-2055-1
[BI-2055] - Remove missingValueString tablesaw values
2 parents a6e7dcb + 1688c71 commit 68a39fc

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

core/src/main/java/tech/tablesaw/io/TypeUtils.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,12 @@
2323
public final class TypeUtils {
2424

2525
/** Strings representing missing values in, for example, a CSV file that is being imported */
26-
private static final String missingInd1 = "NaN";
27-
28-
private static final String missingInd2 = "*";
29-
private static final String missingInd3 = "NA";
3026
private static final String missingInd4 = "null";
31-
private static final String missingInd5 = "N/A";
3227

33-
// No default missing indicators
28+
// Only null should be default missing indicator for now. null will be removed in BI-2486
3429
// TODO: Allow this to be configurable?
3530
public static final ImmutableList<String> MISSING_INDICATORS =
36-
ImmutableList.of(missingInd1, missingInd2, missingInd4, missingInd5);
31+
ImmutableList.of(missingInd4);
3732

3833
/** Private constructor to prevent instantiation */
3934
private TypeUtils() {}

core/src/test/java/tech/tablesaw/io/csv/CsvReaderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -528,7 +528,7 @@ void testWithMissingValue2() throws IOException {
528528

529529
Table t = Table.read().csv("../data/missing_values2.csv");
530530
assertEquals(1, t.stringColumn(0).countMissing());
531-
assertEquals(1, t.numberColumn(1).countMissing());
531+
assertEquals(0, t.numberColumn(1).countMissing());
532532
assertEquals(0, t.numberColumn(2).countMissing());
533533
}
534534

0 commit comments

Comments
 (0)