Improve the rendering of test_diagnosis_t // string

This concatenation now automatically inserts a ": " delimiter
between the resulting diagnostic strings, to provide more natural behavior for
clients who shouldn't need to provide strings that begin with a delimiter

Author: bonachea

src/julienne/julienne_test_diagnosis_s.F90

@@ -25,15 +25,15 @@
     if (lhs%test_passed_) then
       lhs_cat_rhs = lhs
     else
-      lhs_cat_rhs = test_diagnosis_t(lhs%test_passed_, lhs%diagnostics_string_ // rhs)
+      lhs_cat_rhs = test_diagnosis_t(lhs%test_passed_, lhs%diagnostics_string_ // ": " // rhs)
     end if
   end procedure
 
   module procedure append_character_if_test_failed
     if (lhs%test_passed_) then
       lhs_cat_rhs = lhs
     else
-      lhs_cat_rhs = test_diagnosis_t(lhs%test_passed_, lhs%diagnostics_string_ // rhs)
+      lhs_cat_rhs = test_diagnosis_t(lhs%test_passed_, lhs%diagnostics_string_ // ": " // rhs)
     end if
   end procedure
 

test/modules/test_diagnosis_test_m.F90

@@ -259,20 +259,20 @@ function check_string_concatentation() result(test_diagnosis)
     type(test_diagnosis_t) test_diagnosis
 
 #ifndef __GFORTRAN__
-    associate(diagnosis_cat_string => test_diagnosis_t(test_passed=.false., diagnostics_string="blah blah") // string_t(" yada yada"))
-      test_diagnosis = diagnosis_cat_string%diagnostics_string() .equalsExpected. "blah blah yada yada"
+    associate(diagnosis_cat_string => test_diagnosis_t(test_passed=.false., diagnostics_string="blah blah") // string_t("yada yada"))
+      test_diagnosis = diagnosis_cat_string%diagnostics_string() .equalsExpected. "blah blah: yada yada"
     end associate
-    associate(diagnosis_do_not_cat_string => test_diagnosis_t(test_passed=.true., diagnostics_string="blah blah") // string_t(" yada yada"))
+    associate(diagnosis_do_not_cat_string => test_diagnosis_t(test_passed=.true., diagnostics_string="blah blah") // string_t("yada yada"))
       test_diagnosis = test_diagnosis .also. (diagnosis_do_not_cat_string%diagnostics_string() .equalsExpected. "blah blah")
     end associate
 #else
     block
       type(test_diagnosis_t) diagnosis_cat_string, diagnosis_do_not_cat_string
 
-      diagnosis_cat_string = test_diagnosis_t(test_passed=.false., diagnostics_string="blah blah") // string_t(" yada yada")
-      test_diagnosis = diagnosis_cat_string%diagnostics_string() .equalsExpected. "blah blah yada yada"
+      diagnosis_cat_string = test_diagnosis_t(test_passed=.false., diagnostics_string="blah blah") // string_t("yada yada")
+      test_diagnosis = diagnosis_cat_string%diagnostics_string() .equalsExpected. "blah blah: yada yada"
 
-      diagnosis_do_not_cat_string = test_diagnosis_t(test_passed=.true., diagnostics_string="blah blah") // string_t(" yada yada")
+      diagnosis_do_not_cat_string = test_diagnosis_t(test_passed=.true., diagnostics_string="blah blah") // string_t("yada yada")
       test_diagnosis = test_diagnosis .also. (diagnosis_do_not_cat_string%diagnostics_string() .equalsExpected. "blah blah")
     end block
 #endif
@@ -281,20 +281,20 @@ function check_string_concatentation() result(test_diagnosis)
   function check_character_concatentation() result(test_diagnosis)
     type(test_diagnosis_t) test_diagnosis
 #ifndef __GFORTRAN__
-    associate(diagnosis_cat_string => test_diagnosis_t(test_passed=.false., diagnostics_string="blah blah") // " yada yada")
-      test_diagnosis = diagnosis_cat_string%diagnostics_string() .equalsExpected. "blah blah yada yada"
+    associate(diagnosis_cat_string => test_diagnosis_t(test_passed=.false., diagnostics_string="blah blah") // "yada yada")
+      test_diagnosis = diagnosis_cat_string%diagnostics_string() .equalsExpected. "blah blah: yada yada"
     end associate
-    associate(diagnosis_do_not_cat_string => test_diagnosis_t(test_passed=.true., diagnostics_string="blah blah") // " yada yada")
+    associate(diagnosis_do_not_cat_string => test_diagnosis_t(test_passed=.true., diagnostics_string="blah blah") // "yada yada")
       test_diagnosis = test_diagnosis .also. (diagnosis_do_not_cat_string%diagnostics_string() .equalsExpected. "blah blah")
     end associate
 #else
     block
       type(test_diagnosis_t) diagnosis_cat_string, diagnosis_do_not_cat_string
 
-      diagnosis_cat_string = test_diagnosis_t(test_passed=.false., diagnostics_string="blah blah") // " yada yada"
-      test_diagnosis = diagnosis_cat_string%diagnostics_string() .equalsExpected. "blah blah yada yada"
+      diagnosis_cat_string = test_diagnosis_t(test_passed=.false., diagnostics_string="blah blah") // "yada yada"
+      test_diagnosis = diagnosis_cat_string%diagnostics_string() .equalsExpected. "blah blah: yada yada"
 
-      diagnosis_do_not_cat_string = test_diagnosis_t(test_passed=.true., diagnostics_string="blah blah") // " yada yada"
+      diagnosis_do_not_cat_string = test_diagnosis_t(test_passed=.true., diagnostics_string="blah blah") // "yada yada"
       test_diagnosis = test_diagnosis .also. (diagnosis_do_not_cat_string%diagnostics_string() .equalsExpected. "blah blah")
     end block
 #endif