refractor(mc): domain contructor

Author: Benncs

apps/libs/mc/public/mc/domain.hpp

@@ -93,7 +93,10 @@ namespace MC
     /**
      * @brief Main constructor
      */
-    ReactorDomain(std::span<double> volumes, std::span<const size_t> neighbors);
+    explicit ReactorDomain(std::span<double> volumes);
+
+    ReactorDomain(double total_volume, std::size_t size);
+
     /**
      * @brief Default destructor
      *

apps/libs/mc/public/mc/mcinit.hpp

@@ -43,10 +43,11 @@ namespace MC
        uint64_t n_particles,
        std::size_t n_samples,
        std::span<double> volumes,
-       std::span<const size_t> neighbors,
+       std::span<const size_t> _neighbors,
        bool uniform_mc_init,
        double& total_mass)
   {
+    (void)_neighbors; // TODO remove
     if constexpr (ConstWeightModelType<Model>)
     {
       if (_logger)
@@ -58,7 +59,7 @@ namespace MC
     }
 
     auto unit = std::make_unique<MonteCarloUnit>();
-    unit->domain = ReactorDomain(volumes, neighbors);
+    unit->domain = ReactorDomain(volumes);
 
     // bool flag_virtual = unit->domain.getNumberCompartments() == 1;
     auto container = ParticlesContainer<Model>(

apps/libs/mc/src/domain.cpp

@@ -22,19 +22,26 @@ namespace MC
     Kokkos::deep_copy(this->inner.liquid_volume, tmp_host_volume);
   }
 
-  ReactorDomain::ReactorDomain() = default;
+  ReactorDomain::ReactorDomain(double total_volume, std::size_t size)
+      : _total_volume(total_volume), size(size)
+  {
+  }
 
-  ReactorDomain::ReactorDomain(std::span<double> volumes,
-                               std::span<const size_t> neighbors)
-      : _total_volume(std::reduce(volumes.begin(), volumes.end(), 0.)),
-        size(volumes.size())
+  ReactorDomain::ReactorDomain() : ReactorDomain(0, 0)
 
   {
     // const auto n_rows = this->getNumberCompartments();
     // const auto n_cols = neighbors.size() / n_rows;
     // setLiquidNeighbors(n_rows, n_cols, neighbors);
   }
 
+  ReactorDomain::ReactorDomain(std::span<double> volumes)
+      : ReactorDomain(std::reduce(volumes.begin(), volumes.end(), 0.),
+                      volumes.size())
+
+  {
+  }
+
   void ReactorDomain::update(std::span<const double> newliquid_volume,
                              std::span<const std::size_t> neighors_flat,
                              std::span<const double> out_flows,