Skip to content

Commit 04dd1fe

Browse files
authored
{Network} az network lb: Remove useless preview information (#29380)
* chore: remove preview in address * chore: remove preview probe threshold * chore: add warning message * chore: refine example title
1 parent 68b6fb4 commit 04dd1fe

File tree

10 files changed

+11
-17
lines changed

10 files changed

+11
-17
lines changed

src/azure-cli/azure/cli/command_modules/network/_help.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4182,7 +4182,7 @@
41824182
type: command
41834183
short-summary: Add an address pool to an IP configuration.
41844184
examples:
4185-
- name: Add an address pool to an IP configuration.
4185+
- name: Add an address pool to an IP configuration. Specify the full backend pool ID of a load balancer when in a different resource group than the specified NIC.
41864186
text: |
41874187
az network nic ip-config address-pool add -g MyResourceGroup --nic-name MyNic \\
41884188
-n MyIpConfig --address-pool MyAddressPool

src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/lb/address_pool/address/__cmd_group.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
@register_command_group(
1515
"network lb address-pool address",
16-
is_preview=True,
1716
)
1817
class __CMDGroup(AAZCommandGroup):
1918
"""Manage backend addresses of the cross-region load balance backend address pool.

src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/lb/address_pool/address/_add.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
@register_command(
1515
"network lb address-pool address add",
16-
is_preview=True,
1716
)
1817
class Add(AAZCommand):
1918
"""Add one backend address into the load balance backend address pool.

src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/lb/address_pool/address/_list.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
@register_command(
1515
"network lb address-pool address list",
16-
is_preview=True,
1716
)
1817
class List(AAZCommand):
1918
"""List all backend addresses of the load balance backend address pool.

src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/lb/address_pool/address/_remove.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
@register_command(
1515
"network lb address-pool address remove",
16-
is_preview=True,
1716
)
1817
class Remove(AAZCommand):
1918
"""Remove one backend address from the load balance backend address pool.

src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/lb/address_pool/address/_show.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
@register_command(
1515
"network lb address-pool address show",
16-
is_preview=True,
1716
)
1817
class Show(AAZCommand):
1918
"""Show the backend address from the load balance backend address pool.

src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/lb/address_pool/address/_update.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
@register_command(
1515
"network lb address-pool address update",
16-
is_preview=True,
1716
)
1817
class Update(AAZCommand):
1918
"""Update the backend address into the load balance backend address pool.

src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/lb/probe/_create.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ def _build_arguments_schema(cls, *args, **kwargs):
8787
options=["--probe-threshold"],
8888
arg_group="Properties",
8989
help={"short-summary": "The number of consecutive successful or failed probes in order to allow or deny traffic from being delivered to this endpoint. It is currently in preview and is not recommended for production workloads. For most scenarios, we recommend maintaining the default value of 1 by not specifying the value of the property.", "long-summary": "After failing the number of consecutive probes equal to this value, the endpoint will be taken out of rotation and require the same number of successful consecutive probes to be placed back in rotation."},
90-
is_preview=True,
9190
)
9291
_args_schema.protocol = AAZStrArg(
9392
options=["--protocol"],

src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/lb/probe/_update.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ def _build_arguments_schema(cls, *args, **kwargs):
8888
options=["--probe-threshold"],
8989
arg_group="Properties",
9090
help={"short-summary": "The number of consecutive successful or failed probes in order to allow or deny traffic from being delivered to this endpoint. It is currently in preview and is not recommended for production workloads. For most scenarios, we recommend maintaining the default value of 1 by not specifying the value of the property.", "long-summary": "After failing the number of consecutive probes equal to this value, the endpoint will be taken out of rotation and require the same number of successful consecutive probes to be placed back in rotation."},
91-
is_preview=True,
9291
nullable=True,
9392
)
9493
_args_schema.protocol = AAZStrArg(

src/azure-cli/azure/cli/command_modules/network/operations/load_balancer.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -728,11 +728,12 @@ def _build_arguments_schema(cls, *args, **kwargs):
728728

729729
def pre_operations(self):
730730
args = self.ctx.args
731-
if has_value(args.probe_threshold):
731+
if has_value(args.number_of_probes):
732732
logger.warning(
733-
"Please note that the parameter --probe-threshold is currently in preview and is not recommended "
734-
"for production workloads. For most scenarios, we recommend maintaining the default value of 1 "
735-
"by not specifying the value of the property."
733+
"The property \"numberOfProbes\" is not respected. Load Balancer health probes will probe up or down "
734+
"immediately after one probe regardless of the property's configured value. To control the number of "
735+
"successful or failed consecutive probes necessary to mark backend instances as healthy or unhealthy, "
736+
"please leverage the property \"probeThreshold\" instead."
736737
)
737738
if has_value(args.request_path) and args.request_path == "":
738739
args.request_path = None
@@ -750,11 +751,12 @@ def _build_arguments_schema(cls, *args, **kwargs):
750751

751752
def pre_operations(self):
752753
args = self.ctx.args
753-
if has_value(args.probe_threshold):
754+
if has_value(args.number_of_probes):
754755
logger.warning(
755-
"Please note that the parameter --probe-threshold is currently in preview and is not recommended "
756-
"for production workloads. For most scenarios, we recommend maintaining the default value of 1 "
757-
"by not specifying the value of the property."
756+
"The property \"numberOfProbes\" is not respected. Load Balancer health probes will probe up or down "
757+
"immediately after one probe regardless of the property's configured value. To control the number of "
758+
"successful or failed consecutive probes necessary to mark backend instances as healthy or unhealthy, "
759+
"please leverage the property \"probeThreshold\" instead."
758760
)
759761
if has_value(args.request_path) and args.request_path == "":
760762
args.request_path = None

0 commit comments

Comments
 (0)