copilot suggestion updates and style fixes

Author: nafizhaider32

src/aosm/azext_aosm/common/registry.py

@@ -243,13 +243,13 @@ def copy_image_to_target_acr(
             # the format of input.json. Our usage here won't work cross-tenant since
             # we're attempting to get the token (source) with the same context as that
             # in which we are creating the ACR (i.e. the target tenant)
-            
+
             # Get access token with ACR scope to ensure proper repository permissions
             get_token_cmd = [
-                str(shutil.which("az")), 
-                "account", 
-                "get-access-token", 
-                "--scope", 
+                str(shutil.which("az")),
+                "account",
+                "get-access-token",
+                "--scope",
                 ACR_OAUTH_SCOPE
             ]
             # Dont use call_subprocess_raise_output here as we don't want to log the
@@ -283,7 +283,7 @@ def copy_image_to_target_acr(
         try:
             # Extract source registry name for the --registry parameter
             source_registry_name = self.registry_name.replace(".azurecr.io", "")
-            
+
             # Get the full resource ID for the source registry
             source_registry_id_cmd = [
                 str(shutil.which("az")),
@@ -296,14 +296,23 @@ def copy_image_to_target_acr(
                 "--output",
                 "tsv"
             ]
-            called_process = subprocess.run(  # noqa: S603
-                source_registry_id_cmd,
-                encoding="utf-8",
-                capture_output=True,
-                text=True,
-                check=True,
-            )
-            source_registry_id = called_process.stdout.strip()
+            try:
+                called_process = subprocess.run(  # noqa: S603
+                    source_registry_id_cmd,
+                    encoding="utf-8",
+                    capture_output=True,
+                    text=True,
+                    check=True,
+                )
+                source_registry_id = called_process.stdout.strip()
+            except subprocess.CalledProcessError as exc:
+                error_output = exc.stderr or exc.stdout or str(exc)
+                raise ClientRequestError(
+                    "Failed to resolve source registry "
+                    f"'{source_registry_name}'. Please ensure the registry exists "
+                    "and that you have sufficient permissions. "
+                    f"Details: {error_output}"
+                ) from exc
 
             acr_import_image_cmd = [
                 str(shutil.which("az")),
@@ -362,35 +371,19 @@ def copy_image_to_target_acr(
                 error,
             )
 
-    def _get_subscription_id(self) -> str:
-        """Get the current subscription ID."""
-        try:
-            get_sub_cmd = [str(shutil.which("az")), "account", "show", "--query", "id", "--output", "tsv"]
-            called_process = subprocess.run(  # noqa: S603
-                get_sub_cmd,
-                encoding="utf-8",
-                capture_output=True,
-                text=True,
-                check=True,
-            )
-            return called_process.stdout.strip()
-        except subprocess.CalledProcessError as error:
-            logger.debug(error, exc_info=True)
-            raise ClientRequestError("Failed to get subscription ID") from error
-
     def _get_source_acr_resource_group(self) -> str:
         """Get the resource group name for the source ACR."""
         try:
             registry_name_without_domain = self.registry_name.replace(".azurecr.io", "")
             get_rg_cmd = [
-                str(shutil.which("az")), 
-                "acr", 
-                "show", 
-                "--name", 
-                registry_name_without_domain, 
-                "--query", 
-                "resourceGroup", 
-                "--output", 
+                str(shutil.which("az")),
+                "acr",
+                "show",
+                "--name",
+                registry_name_without_domain,
+                "--query",
+                "resourceGroup",
+                "--output",
                 "tsv"
             ]
             called_process = subprocess.run(  # noqa: S603