Merge pull request #787 from LockTar/f/fix-409-conflict-errorcode

Add retry logic for 409 response with specific Conflict error code

Author: waelkdouh

tools/code/common/Http.cs

@@ -402,6 +402,7 @@ private static bool ShouldRetryInner(HttpMessage message, Exception? exception)
                 (message, exception) switch
                 {
                     ({ Response.Status: 422 or 409 }, _) when HasManagementApiRequestFailedError(message.Response) => true,
+                    ({ Response.Status: 409 }, _) when HasConflictError(message.Response) && HasOperationOnTheApiIsInProgressMessage(message.Response) => true,
                     ({ Response.Status: 412 }, _) => true,
                     ({ Response.Status: 429 }, _) => true,
                     _ => false
@@ -418,6 +419,16 @@ private static bool HasManagementApiRequestFailedError(Response response) =>
             .Where(code => code.Equals("ManagementApiRequestFailed", StringComparison.OrdinalIgnoreCase))
             .IsSome;
 
+    private static bool HasConflictError(Response response) =>
+        TryGetErrorCode(response)
+            .Where(code => code.Equals("Conflict", StringComparison.OrdinalIgnoreCase))
+            .IsSome;
+
+    private static bool HasOperationOnTheApiIsInProgressMessage(Response response) =>
+        TryGetMessage(response)
+            .Where(code => code.Equals("Operation on the API is in progress", StringComparison.OrdinalIgnoreCase))
+            .IsSome;
+
     private static Option<string> TryGetErrorCode(Response response)
     {
         try
@@ -433,6 +444,22 @@ private static Option<string> TryGetErrorCode(Response response)
             return Option<string>.None;
         }
     }
+
+    private static Option<string> TryGetMessage(Response response)
+    {
+        try
+        {
+            return response.Content
+                           .ToObjectFromJson<JsonObject>()
+                           .TryGetJsonObjectProperty("error")
+                           .Bind(error => error.TryGetStringProperty("message"))
+                           .ToOption();
+        }
+        catch (Exception exception) when (exception is ArgumentNullException or NotSupportedException or JsonException)
+        {
+            return Option<string>.None;
+        }
+    }
 }
 
 public class TelemetryPolicy(Version version) : HttpPipelinePolicy