Skip to content

Commit bb15f15

Browse files
Merge pull request #9 from AtlasSystems/feature/29032/HandleBlankIdSuffix
Mark IdSuffix setting as required, log error if the setting is left b…
2 parents 7dacbc7 + 240e2dd commit bb15f15

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

Catalog.lua

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,12 @@ function Init()
137137

138138
OnFormClosing:RegisterFormClosingEvent(interfaceMngr, StopRecordPageWatcher);
139139

140+
if settings.IdSuffix == "" then
141+
interfaceMngr:ShowMessage("The IdSuffix setting is blank. Please update your configuration to include a value for this setting.", "Configuration Error - Primo Definitive addon");
142+
log:Error("The IdSuffix setting is blank. Please update your configuration to include a value for this setting.");
143+
return;
144+
end
145+
140146
if settings.AutoSearch and identifier and identifier > 0 then
141147
log:Debug("Performing AutoSearch");
142148

Config.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<Configuration xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
33
<Name>Alma Primo Definitive Catalog Search</Name>
44
<Author>Atlas Systems</Author>
5-
<Version>1.2.1</Version>
5+
<Version>1.2.2</Version>
66
<Active>True</Active>
77
<Type>Addon</Type>
88
<Description>Catalog Search and Import Addon that uses Alma as the catalog and Primo or Primo VE as the discovery layer.</Description>
@@ -43,7 +43,7 @@
4343
<Description>The code that identifies the site in Primo Deep Links. Ex: vid={PrimoSiteCode}</Description>
4444
</Setting>
4545
<Setting name="IdSuffix" value="" type="string">
46-
<Description>The last four digits of MMS IDs and IE IDs for your institution.</Description>
46+
<Description>The last four digits of MMS IDs and IE IDs for your institution. This setting is required and should not be left blank.</Description>
4747
</Setting>
4848
</Settings>
4949
<Files>

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ The addon is located within an request or item record of an Atlas Product. It is
3636
>
3737
>**PrimoSiteCode:** The code that identifies the site in Primo Deep Links. Ex: vid={PrimoSiteCode}
3838
>
39-
>**IdSuffix:** The last four digits of MMS IDs and IE IDs for your institution. These can be found in the URL of any record opened from the results list.
39+
>**IdSuffix:** The last four digits of MMS IDs and IE IDs for your institution. These can be found in the URL of any record opened from the results list. This setting is required and should not be left blank.
4040
4141

4242
## Buttons

0 commit comments

Comments
 (0)