Merge pull request #168 from AthennaIO/develop

feat: download without saving file

Author: jlenon7

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@athenna/common",
-  "version": "5.19.0",
+  "version": "5.21.0",
   "description": "The Athenna common helpers to use in any Node.js ESM project.",
   "license": "MIT",
   "author": "João Lenon <[email protected]>",

package.json

@@ -214,18 +214,30 @@ export class Exec extends Macroable {
     }
   }
 
+  public static download(url: string): Promise<any>
+  public static download(
+    url: string,
+    options?: { path?: string }
+  ): Promise<File>
+
   /**
-   * Download an archive to a determined path.
+   * Download the data of an URL.
    */
-  public static async download(path: string, url: string): Promise<File> {
+  public static async download(url: string, options?: { path?: string }) {
     return new Promise((resolve, reject) => {
       const callback = response => {
         const data = new Transform()
 
         response.on('data', chunk => data.push(chunk))
 
-        response.on('end', function () {
-          resolve(new File(path, data.read()).loadSync())
+        response.on('end', () => {
+          if (options.path) {
+            resolve(new File(options.path, data.read()).loadSync())
+
+            return
+          }
+
+          resolve(data.read())
         })
 
         response.on('error', error => reject(error))

src/helpers/Exec.ts

@@ -220,10 +220,9 @@ export default class ExecTest {
 
   @Test()
   public async shouldBeAbleToDownloadFiles({ assert }: Context) {
-    const file = await Exec.download(
-      Path.storage('downloads/node.pkg'),
-      'https://nodejs.org/dist/v23.5.0/node-23.5.0.pkg'
-    )
+    const file = await Exec.download('https://nodejs.org/dist/v23.5.0/node-23.5.0.pkg', {
+      path: Path.storage('downloads/node.pkg')
+    })
 
     assert.equal(file.base, 'node.pkg')
     assert.isTrue(await File.exists(file.path))