Use a separate class for concrete generic parameters

Author: ds5678

Cpp2IL.Core/Model/Contexts/ConcreteGenericMethodAnalysisContext.cs

@@ -1,9 +1,7 @@
 using System;
-using System.Linq;
 using System.Reflection;
 using Cpp2IL.Core.Utils;
 using LibCpp2IL;
-using LibCpp2IL.BinaryStructures;
 using LibCpp2IL.Reflection;
 
 namespace Cpp2IL.Core.Model.Contexts;
@@ -107,15 +105,12 @@ private ConcreteGenericMethodAnalysisContext(Cpp2IlMethodRef? methodRef, MethodA
         for (var i = 0; i < BaseMethodContext.Parameters.Count; i++)
         {
             var parameter = BaseMethodContext.Parameters[i];
-            var parameterType = parameter.ParameterTypeContext;
             var instantiatedType = GenericInstantiation.Instantiate(
                 parameter.ParameterTypeContext,
                 typeGenericParameters,
                 methodGenericParameters);
 
-            Parameters.Add(parameterType == instantiatedType
-                ? parameter
-                : new InjectedParameterAnalysisContext(parameter.Name, instantiatedType, parameter.ParameterAttributes, i, BaseMethodContext));
+            Parameters.Add(new ConcreteGenericParameterAnalysisContext(parameter, instantiatedType, this));
         }
 
         InjectedReturnType = GenericInstantiation.Instantiate(BaseMethodContext.ReturnTypeContext, typeGenericParameters, methodGenericParameters);

Cpp2IL.Core/Model/Contexts/ConcreteGenericParameterAnalysisContext.cs

@@ -0,0 +1,23 @@
+using System;
+using System.Diagnostics;
+using System.Reflection;
+using LibCpp2IL.BinaryStructures;
+
+namespace Cpp2IL.Core.Model.Contexts;
+
+public class ConcreteGenericParameterAnalysisContext : ParameterAnalysisContext
+{
+    public ParameterAnalysisContext BaseParameterContext { get; }
+    public override TypeAnalysisContext ParameterTypeContext { get; }
+    public override ParameterAttributes ParameterAttributes => BaseParameterContext.ParameterAttributes;
+    public override Il2CppType ParameterType => throw new NotSupportedException($"Instantiated generic parameters don't have an {nameof(Il2CppType)}");
+    public override string DefaultName => BaseParameterContext.DefaultName;
+    public override string? OverrideName { get => BaseParameterContext.OverrideName; set => BaseParameterContext.OverrideName = value; }
+    protected override int CustomAttributeIndex => -1;
+
+    public ConcreteGenericParameterAnalysisContext(ParameterAnalysisContext baseParameter, TypeAnalysisContext parameterType, ConcreteGenericMethodAnalysisContext declaringMethod) : base(null, baseParameter.ParamIndex, declaringMethod)
+    {
+        BaseParameterContext = baseParameter;
+        ParameterTypeContext = parameterType;
+    }
+}