Skip to content

Commit dabf605

Browse files
committed
fix: remove secrets from if condition in promote-release workflow
GitHub Actions doesn't allow secrets in if conditions. Using continue-on-error instead to gracefully handle missing webhook.
1 parent 4ecbc37 commit dabf605

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

.github/workflows/promote-release.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,6 @@ jobs:
197197

198198
steps:
199199
- name: 📨 Send Slack notification
200-
if: ${{ secrets.CI_SLACK_WEBHOOK_URL != '' }}
201200
uses: slackapi/slack-github-action@v1
202201
with:
203202
payload: |
@@ -206,4 +205,4 @@ jobs:
206205
}
207206
env:
208207
SLACK_WEBHOOK_URL: ${{ secrets.CI_SLACK_WEBHOOK_URL }}
209-
continue-on-error: true
208+
continue-on-error: true # Will gracefully fail if webhook not configured

0 commit comments

Comments
 (0)