Fixed bool and NSManagedObject comparison predicate

Author: ABridoux

Sources/SafeFetching/Predicate/DatabaseTestValue.swift

@@ -3,13 +3,20 @@
 // Copyright © 2021-present Alexis Bridoux.
 // MIT license, see LICENSE file for details
 
+import CoreData
+
 /// A type that can be used in a predicate as a test value
+///
+/// - Default implementations are provided to ensure formatting.
+/// - Implementation for `NSManagedObject`  is provided (for the relationships) and will use the [`objectID`](https://developer.apple.com/documentation/coredata/nsmanagedobject/1506848-objectid) property
 public protocol DatabaseTestValue {
 
     /// Formatted string value that can be used in the format of a `NSPredicate`
     var testValue: String { get }
 }
 
+// MARK: - Scalar
+
 extension String: DatabaseTestValue {
 
     public var testValue: String { #""\#(self)""# }
@@ -45,29 +52,46 @@ extension Float: DatabaseTestValue {
     public var testValue: String { String(describing: self) }
 }
 
+extension Bool: DatabaseTestValue {
+    public var testValue: String { String(describing: self) }
+}
+
+// MARK: - Optional
+
 extension Optional: DatabaseTestValue where Wrapped: DatabaseTestValue {
 
     public var testValue: String {
         switch self {
         case .none: return "nil"
-        case .some(let wrapped):
+        case let .some(wrapped):
             return wrapped.testValue
         }
     }
 }
 
+extension NSManagedObject: DatabaseTestValue {
+
+    public var testValue: String { String(describing: objectID) }
+}
+
+// MARK: - Array
+
 extension Array: DatabaseTestValue where Element: DatabaseTestValue {
 
     public var testValue: String {
         "{ \(map(\.testValue).joined(separator: ","))}"
     }
 }
 
+// MARK: - RawRepresentable
+
 extension DatabaseTestValue where Self: RawRepresentable, RawValue: DatabaseValue {
 
     public var testValue: String { String(describing: rawValue) }
 }
 
+// MARK: - Range
+
 extension ClosedRange: DatabaseTestValue where Bound: Numeric {
 
     public var testValue: String {

Sources/SafeFetching/Predicate/DatabaseValue.swift

@@ -71,6 +71,10 @@ extension URL: DatabaseValue {
 
 // MARK:  Relationship
 
+extension NSManagedObject: DatabaseValue {
+    public static let identification = DatabaseValueIdentification()
+}
+
 extension Set: DatabaseValue where Element: NSManagedObject {
     public static var identification: DatabaseValueIdentification {
         DatabaseValueIdentification()

Tests/SafeFetchingTests/BooleanPredicateBuilderTests.swift

@@ -15,7 +15,10 @@ final class BooleanPredicateTests: XCTestCase {
         testNSFormat(predicate: \.score >= 10, expecting: "score >= 10")
         testNSFormat(predicate: \.score < 10, expecting: "score < 10")
         testNSFormat(predicate: \.score <= 10, expecting: "score <= 10")
+        testNSFormat(predicate: \.isAdmin == true, expecting: "isAdmin == 1")
+        testNSFormat(predicate: \.isAdmin == false, expecting: "isAdmin == 0")
         testNSFormat(predicate: \.property == nil, expecting: "property == nil")
+        testNSFormat(predicate: \.stubRelationship == nil, expecting: "stubRelationship == nil")
     }
 
     func testString() {
@@ -109,11 +112,14 @@ extension BooleanPredicateTests {
 
     final class StubEntity: NSManagedObject {
 
+        @objc var isAdmin = false
         @objc var score = 0.0
         @objc var property: String? = ""
         @objc var stubRawValue: Int = 0
         @objc var stubRawOption: Int = 0
 
+        @objc var stubRelationship: StubEntity?
+
         var stubRaw: StubEnum? { StubEnum(rawValue: stubRawValue) }
         var stubForcedRaw: StubEnum { StubEnum(rawValue: stubRawValue)! }