Skip to content

Commit d02ebbd

Browse files
authored
Merge pull request #252 from rchristie/field_compare_none
Avoid testing equality of Field and None
2 parents 6d9b67c + e421f74 commit d02ebbd

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/scaffoldmaker/annotation/annotationgroup.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,10 @@ def setMarkerMaterialCoordinates(self, materialCoordinatesField, materialCoordin
357357
markerNode = nodes.findNodeByIdentifier(self._markerIdentifier)
358358
with ChangeManager(fieldmodule):
359359
oldMaterialCoordinatesField, oldMaterialCoordinates = self.getMarkerMaterialCoordinates()
360-
if materialCoordinatesField != oldMaterialCoordinatesField:
360+
# comparing Zinc Field with None fails on some Python implementations:
361+
if ((materialCoordinatesField and not oldMaterialCoordinatesField) or
362+
(oldMaterialCoordinatesField and not materialCoordinatesField) or
363+
(materialCoordinatesField != oldMaterialCoordinatesField)):
361364
nodetemplate = nodes.createNodetemplate()
362365
if self._markerMaterialCoordinatesField:
363366
assert RESULT_OK == nodetemplate.undefineField(self._markerMaterialCoordinatesField)

0 commit comments

Comments
 (0)